Skip to content

Commit 6ce8f85

Browse files
committed
fix: dev server urls not passed to msha correctly
1 parent 11fe14d commit 6ce8f85

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

src/cli/commands/start/start.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,9 @@ export async function start(options: SWACLIConfig) {
285285
SWA_CLI_VERSION: packageInfo.version,
286286
SWA_CLI_SERVER_TIMEOUT: `${devserverTimeout}`,
287287
SWA_CLI_OPEN_BROWSER: open ? "true" : "false",
288+
SWA_CLI_APP_DEVSERVER_URL: appDevserverUrl,
289+
SWA_CLI_API_DEVSERVER_URL: useApiDevServer,
290+
SWA_CLI_DATA_API_DEVSERVER_URL: useDataApiDevServer,
288291
};
289292

290293
// merge SWA CLI env variables with process.env

src/core/constants.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ export const GIT_IGNORE_FILENAME = ".gitignore";
287287

288288
export const SWA_CLI_APP_PROTOCOL = DEFAULT_CONFIG.ssl ? `https` : `http`;
289289
export const SWA_PUBLIC_DIR = path.resolve(__dirname, "..", "public"); //SWA_PUBLIC_DIR = "../public"
290-
export const HAS_API = Boolean(DEFAULT_CONFIG.apiLocation && SWA_CLI_API_URI());
290+
export const HAS_API = Boolean((DEFAULT_CONFIG.apiLocation || DEFAULT_CONFIG.apiDevserverUrl) && SWA_CLI_API_URI());
291291

292292
export const SWA_CONFIG_FILENAME = "staticwebapp.config.json";
293293
export const SWA_CONFIG_FILENAME_LEGACY = "routes.json";
@@ -318,21 +318,21 @@ export const DEFAULT_RUNTIME_LANGUAGE = "node";
318318
// The reason for this is that these function depend on values set by environment variables which are set
319319
// during the startup of the CLI (see src/cli/commands/start.ts)
320320
export function IS_APP_DEV_SERVER() {
321-
return isHttpUrl(DEFAULT_CONFIG.outputLocation);
321+
return isHttpUrl(DEFAULT_CONFIG.appDevserverUrl) || isHttpUrl(DEFAULT_CONFIG.outputLocation);
322322
}
323323
export function IS_API_DEV_SERVER() {
324-
return isHttpUrl(DEFAULT_CONFIG.apiLocation);
324+
return isHttpUrl(DEFAULT_CONFIG.apiDevserverUrl);
325325
}
326326
export function SWA_CLI_API_URI() {
327-
return IS_API_DEV_SERVER() ? DEFAULT_CONFIG.apiLocation : address(DEFAULT_CONFIG.host, DEFAULT_CONFIG.apiPort);
327+
return IS_API_DEV_SERVER() ? DEFAULT_CONFIG.apiDevserverUrl : address(DEFAULT_CONFIG.host, DEFAULT_CONFIG.apiPort);
328328
}
329329

330330
export function IS_DATA_API_DEV_SERVER() {
331-
return isHttpUrl(DEFAULT_CONFIG.dataApiLocation);
331+
return isHttpUrl(DEFAULT_CONFIG.dataApiDevserverUrl);
332332
}
333333

334334
export function SWA_CLI_DATA_API_URI() {
335-
return IS_DATA_API_DEV_SERVER() ? DEFAULT_CONFIG.dataApiLocation : address(DEFAULT_CONFIG.host, DEFAULT_CONFIG.dataApiPort, "http");
335+
return IS_DATA_API_DEV_SERVER() ? DEFAULT_CONFIG.dataApiDevserverUrl : address(DEFAULT_CONFIG.host, DEFAULT_CONFIG.dataApiPort, "http");
336336
}
337337

338338
// Constants related to swa login

0 commit comments

Comments
 (0)