Merge pull request #862 from adrianhall/issues/684

(#684) Move to ESM, Fix for CVE audit failures

Author: Timothyw0

.github/workflows/azuresdkdrop.yml

@@ -14,14 +14,14 @@ jobs:
     strategy:
       matrix:
         os: [macos-12, windows-latest, ubuntu-latest]
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [18.x, 20.x]
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         ref: main
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
     - run: npm ci
@@ -32,11 +32,11 @@ jobs:
     name: Package / tag / release
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           ref: main
       - name: Use Node.js 18.x
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: 18.x
 
@@ -99,7 +99,7 @@ jobs:
       uses: actions/download-artifact@v2
       with:
           name: package
-          
+
     # Login via OIDC to permit uploading to azure drops blob store
     - name: 'Az login'
       uses: azure/login@v2
@@ -115,4 +115,4 @@ jobs:
         ls -la
         PACKAGE_ID=`echo $(ls *.tgz) | sed -e 's/\.tgz$//'`
         echo $PACKAGE_ID
-        az storage blob upload -n azure-staticwebapps/npm/$PACKAGE_ID/$(ls *.tgz) -c drops -f $(ls *.tgz) --account-name azuresdkpartnerdrops --auth-mode login
+        az storage blob upload -n azure-staticwebapps/npm/$PACKAGE_ID/$(ls *.tgz) -c drops -f $(ls *.tgz) --account-name azuresdkpartnerdrops --auth-mode login

.github/workflows/ci.yml

@@ -14,8 +14,8 @@ jobs:
   format:
     runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 18.x
 
@@ -28,18 +28,18 @@ jobs:
     strategy:
       matrix:
         os: [macos-12]
-        node-version: [14.x, 15.x, 16.x, 17.x, 18.x]
+        node-version: [18.x, 20.x]
 
     name: "test: use node ${{ matrix.node-version }}"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Cache node modules
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules-${{ matrix.os }}-${{ matrix.node-version }}
         with:
@@ -59,18 +59,18 @@ jobs:
     strategy:
       matrix:
         os: [macos-12]
-        node-version: [14.x, 15.x, 16.x, 17.x, 18.x]
+        node-version: [18.x, 20.x]
 
     name: "deploy: use node ${{ matrix.node-version }}"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Cache node modules
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules-${{ matrix.os }}-${{ matrix.node-version }}
         with:
@@ -92,18 +92,18 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        node-version: [14.x, 15.x, 16.x, 17.x, 18.x]
+        node-version: [18.x, 20.x]
 
     name: "test: use node ${{ matrix.node-version }}"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Cache node modules
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules-${{ matrix.os }}-${{ matrix.node-version }}
         with:
@@ -115,26 +115,26 @@ jobs:
       - name: "npm test"
         run: |
           npm ci
-          npm test -- --maxWorkers=1
+          npm test
 
   e2e-deploy-windows:
     needs: [test-windows]
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         os: [windows-latest]
-        node-version: [14.x, 15.x, 16.x, 17.x, 18.x]
+        node-version: [18.x, 20.x]
 
     name: "deploy: use node ${{ matrix.node-version }}"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Cache node modules
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules-${{ matrix.os }}-${{ matrix.node-version }}
         with:
@@ -156,18 +156,18 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04]
-        node-version: [14.x, 15.x, 16.x, 17.x, 18.x]
+        node-version: [18.x, 20.x]
 
     name: "test: use node ${{ matrix.node-version }}"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Cache node modules
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules-${{ matrix.os }}-${{ matrix.node-version }}
         with:
@@ -187,18 +187,18 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04]
-        node-version: [14.x, 15.x, 16.x, 17.x, 18.x]
+        node-version: [18.x, 20.x]
 
     name: "deploy: use node ${{ matrix.node-version }}"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Cache node modules
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules-${{ matrix.os }}-${{ matrix.node-version }}
         with:
@@ -219,8 +219,8 @@ jobs:
     runs-on: ubuntu-20.04
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 18.x
 

.github/workflows/codeql-analysis.yml

@@ -40,7 +40,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

.github/workflows/deploy-docs.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Build and Deploy Job
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - run: git config --global user.email "github@wassim.dev"
       - run: git config --global user.name "Wassim Chegham"
       - name: Setup Node.js environment

.github/workflows/detection-e2e-tests.yml

@@ -7,8 +7,8 @@ jobs:
   detection-e2e-tests:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-node@v1
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
       with:
         node-version: 14.x
     - name: Test framework detection

.github/workflows/e2e.yml

@@ -16,11 +16,11 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-12, windows-latest, ubuntu-20.04]
-        node-version: [14.x, 15.x, 16.x, 17.x]
+        node-version: [18.x, 20.x]
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Cypress run
         uses: cypress-io/github-action@v2

.nvmrc

@@ -1 +1 @@
-16
+18

.vscode/extensions.json

@@ -1,10 +1,3 @@
 {
-  "recommendations": [
-    "dbaeumer.vscode-eslint",
-    "editorconfig.editorconfig",
-    "esbenp.prettier-vscode",
-    "eg2.vscode-npm-script",
-    "visualstudioexptteam.vscodeintellicode",
-    "tht13.html-preview-vscode"
-  ]
+  "recommendations": ["dbaeumer.vscode-eslint", "editorconfig.editorconfig", "esbenp.prettier-vscode", "visualstudioexptteam.vscodeintellicode"]
 }

.vscode/launch.json

@@ -1,19 +1,3 @@
 {
-  "configurations": [
-    {
-      "command": "npm start",
-      "name": "Run npm start",
-      "request": "launch",
-      "type": "node-terminal"
-    },
-    {
-      "type": "node-terminal",
-      "request": "launch",
-      "name": "Jest Tests",
-      "command": "node ${workspaceRoot}/node_modules/jest/bin/jest.js -i",
-      // "args": ["-i"],
-      "preLaunchTask": "build",
-      "internalConsoleOptions": "openOnSessionStart"
-    }
-  ]
+  "configurations": []
 }

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "typescript.tsdk": "node_modules\\typescript\\lib"
+}