fix: handle the case when statusCode is a string

Closes #114

Author: manekinekko

.github/labeler.yml

@@ -3,9 +3,12 @@
 
 "scope: cli":
   - src/cli/*
-  
+
 "scope: auth":
   - src/auth/*
- 
+
+"scope: rules engine":
+  - src/proxy/routes-engine/*
+
 "scope: proxy":
   - src/proxy/*

src/proxy/routes-engine/rules/customRoutes.spec.ts

@@ -132,7 +132,7 @@ describe("customRoutes()", () => {
     expect(res.statusCode).toBe(200);
   });
 
-  it("should set custom status code (418)", async () => {
+  it("should set custom status code as number (statusCode=418)", async () => {
     userConfig = [
       {
         route: "/foo",
@@ -144,7 +144,31 @@ describe("customRoutes()", () => {
     expect(res.statusCode).toBe(418);
   });
 
-  it("should set custom status code (404)", async () => {
+  it("should set custom status code as string (statusCode='418')", async () => {
+    userConfig = [
+      {
+        route: "/foo",
+        statusCode: "418",
+      },
+    ];
+    await customRoutes(req, res, userConfig, false);
+
+    expect(res.statusCode).toBe(418);
+  });
+
+  it("should not set custom status code if invalid code (statusCode='NaN')", async () => {
+    userConfig = [
+      {
+        route: "/foo",
+        statusCode: "NaN",
+      },
+    ];
+    await customRoutes(req, res, userConfig, false);
+
+    expect(res.statusCode).toBe(200);
+  });
+
+  it("should set custom status code (statusCode=404)", async () => {
     userConfig = [
       {
         route: "/foo",
@@ -234,7 +258,7 @@ describe("customRoutes()", () => {
     expect(req.url).toBe("/bar");
   });
 
-  it("should serve with rewrite (statusCode = undefined)", async () => {
+  it("should serve with rewrite (statusCode=undefined)", async () => {
     userConfig = [
       {
         route: "/foo",

src/proxy/routes-engine/rules/customRoutes.ts

@@ -92,24 +92,27 @@ export const customRoutes = async (
 
     // specific status code but no attached route
     if (userDefinedRoute.statusCode && !userDefinedRoute.serve) {
-      res.statusCode = userDefinedRoute.statusCode;
+      const code = Number(userDefinedRoute.statusCode);
+      if (isNaN(code) === false) {
+        res.statusCode = code;
+      }
     }
 
     // rewrite
-    const isServeWrite = userDefinedRoute.serve && ![301, 302].includes(userDefinedRoute.statusCode!);
+    const isServeWrite = userDefinedRoute.serve && ![301, 302].includes(Number(userDefinedRoute.statusCode));
     if (isServeWrite || userDefinedRoute.rewrite) {
       req.url = userDefinedRoute.serve || userDefinedRoute.rewrite;
     }
 
     // redirect route
-    const isServeRedirect = userDefinedRoute.serve && [301, 302].includes(userDefinedRoute.statusCode!);
+    const isServeRedirect = userDefinedRoute.serve && [301, 302].includes(Number(userDefinedRoute.statusCode));
     if (isServeRedirect || userDefinedRoute.redirect) {
       let route = (userDefinedRoute.serve || userDefinedRoute.redirect) as string;
 
       // redirects
       // note: adding checks to avoid ERR_TOO_MANY_REDIRECTS
       if (route !== req.url) {
-        res.writeHead(userDefinedRoute.statusCode || 302, {
+        res.writeHead(Number(userDefinedRoute.statusCode) || 302, {
           Location: route,
         });
         res.end();

src/swa.d.ts

@@ -82,7 +82,7 @@ declare type ClientPrincipal = {
 declare type SWAConfigFileRoute = {
   route: string;
   allowedRoles?: string[];
-  statusCode?: number;
+  statusCode?: number | string;
   serve?: string;
   headers?: { [key: string]: string };
   methods?: string[];