Skip to content

Commit fdc0b8f

Browse files
committed
Remove PassThrough pipe
1 parent 21db4b9 commit fdc0b8f

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

src/core/download-binary-helper.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import stp from "node:stream/promises";
55
import { fetchWithProxy as fetch } from "./utils/fetch-proxy.js";
66
import ora from "ora";
77
import path from "node:path";
8-
import { PassThrough } from "node:stream";
98
import { DATA_API_BUILDER_BINARY_NAME, DATA_API_BUILDER_FOLDER, DEPLOY_BINARY_NAME, DEPLOY_FOLDER } from "./constants.js";
109
import { logger } from "./utils/logger.js";
1110

@@ -38,16 +37,14 @@ export async function downloadAndValidateBinary(
3837
throw new Error(`Failed to download ${binaryName} binary from url ${url}. File not found (${response.status})`);
3938
}
4039

41-
const bodyStream = response?.body?.pipe(new PassThrough());
42-
4340
createBinaryDirectoryIfNotExists(id, outputFolder);
4441

4542
const isPosix = platform === "linux-x64" || platform === "osx-x64";
4643
const outputFile = path.join(outputFolder, id, downloadFilename);
4744

4845
const writableStream = fs.createWriteStream(outputFile, { mode: isPosix ? 0o755 : undefined });
4946

50-
await stp.pipeline(bodyStream, writableStream);
47+
await stp.pipeline(response.body, writableStream);
5148

5249
const computedHash = computeChecksumfromFile(outputFile).toLowerCase();
5350
const releaseChecksum = releaseMetadata.files[platform].sha.toLowerCase();

0 commit comments

Comments
 (0)