fix: correct duplicate 'init' property in schema to 'build'#963
Closed
keith-oak wants to merge 1 commit intoAzure:mainfrom
keith-oak:fix-schema-duplicate-init
Closed
fix: correct duplicate 'init' property in schema to 'build'#963keith-oak wants to merge 1 commit intoAzure:mainfrom keith-oak:fix-schema-duplicate-init
keith-oak wants to merge 1 commit intoAzure:mainfrom
keith-oak:fix-schema-duplicate-init
Conversation
The schema had a duplicate 'init' property at line 92 which should have been 'build' since it references buildCommandParameters. This fixes the JSON schema validation issue. Fixes #705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the JSON schema where a duplicate 'init' property should have been 'build'.
Details
The schema file
/schema/swa-cli.config.schema.jsonhad a duplicate 'init' property at line 92 that was referencingbuildCommandParameters. This property should have been named 'build' to match the parameters it references.Changes
"init": {to"build": {Testing
References
Fixes #705
Thanks to @javier-lopez-1s for reporting this issue!