fix: validate --env is not passed with an empty string#999
Open
monteiro-renato wants to merge 1 commit into
Open
fix: validate --env is not passed with an empty string#999monteiro-renato wants to merge 1 commit into
monteiro-renato wants to merge 1 commit into
Conversation
monteiro-renato
requested review from
LongOddCode,
cjk7989 and
jessieyyt
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the CLI accepts --env="", and the deployment seems to "work"; There were no error messages in the console at least.
Looking at the portal it doesn't seem like anything gets deployed however.
I am not exactly sure how I could dig deeper into what happens when the deployment code is actually running, but I guess adding this extra validation can't hurt.