Skip to content

fix: validate --env is not passed with an empty string #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monteiro-renato wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix: validate --env is not passed with an empty string #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cli/commands/deploy/deploy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,5 +307,13 @@ describe("deploy", () => {
expect(env.FUNCTION_LANGUAGE_VERSION).toBe(DEFAULT_VERSION.DotnetIsolated);
expect(SUPPORTED_VERSIONS.DotnetIsolated).toContain(env.FUNCTION_LANGUAGE_VERSION);
});

it("should print an error when --env is an empty string", async () => {
await deploy({
outputLocation: "/test-output",
env: "",
});
expect(logger.error).toHaveBeenNthCalledWith(1, "Invalid --env: cannot be empty. Use 'preview' or omit the flag.");
});
});
});
4 changes: 4 additions & 0 deletions src/cli/commands/deploy/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ export async function deploy(options: SWACLIConfig) {
// set the DEPLOYMENT_ENVIRONMENT env variable only when the user has provided
// a deployment environment which is not "production".
if (options.env?.toLowerCase() !== "production" && options.env?.toLowerCase() !== "prod") {
if (options.env !== undefined && !options.env.trim()) {
logger.error("Invalid --env: cannot be empty. Use 'preview' or omit the flag.");
return;
}
deployClientEnv.DEPLOYMENT_ENVIRONMENT = options.env;
}

Expand Down
Loading