test: add unit tests for job wait_for_condition

Author: diamondpowell

modules/python/tests/clients/test_kubernetes_client.py

@@ -3407,6 +3407,160 @@ def test_wait_for_condition_case_insensitive(self):
                     )
                     self.assertTrue(result)
 
+    # Tests for wait_for_condition with job resource type
+
+    @patch('time.time')
+    def test_wait_for_condition_job_complete_success(self, mock_time):
+        """Test wait_for_condition for a completed job - success case"""
+        mock_time.side_effect = [0, 0, 1, 2, 2]
+
+        mock_job = MagicMock()
+        mock_job.status.completion_time = "2026-04-20T00:00:00Z"
+        mock_job.status.succeeded = 1
+        mock_job.status.failed = None
+        mock_job.status.active = None
+        mock_job.status.conditions = None
+
+        with patch.object(self.client, 'app') as mock_app, \
+             patch('time.sleep'):
+            mock_app.read_namespaced_job.return_value = mock_job
+
+            result = self.client.wait_for_condition(
+                resource_type="job",
+                resource_name="test-job",
+                wait_condition_type="complete",
+                namespace="test-namespace",
+                timeout_seconds=5
+            )
+
+            self.assertTrue(result)
+            mock_app.read_namespaced_job.assert_called_with(
+                name="test-job",
+                namespace="test-namespace"
+            )
+
+    @patch('time.time')
+    def test_wait_for_condition_job_complete_timeout(self, mock_time):
+        """Test wait_for_condition for a job - timeout when not yet complete"""
+        mock_time.side_effect = [0, 0, 2, 5, 6, 6]
+
+        mock_job = MagicMock()
+        mock_job.status.completion_time = None
+        mock_job.status.succeeded = 0
+        mock_job.status.failed = None
+        mock_job.status.active = 1
+        mock_job.status.conditions = None
+
+        with patch.object(self.client, 'app') as mock_app, \
+             patch('time.sleep'):
+            mock_app.read_namespaced_job.return_value = mock_job
+
+            result = self.client.wait_for_condition(
+                resource_type="job",
+                resource_name="test-job",
+                wait_condition_type="complete",
+                namespace="test-namespace",
+                timeout_seconds=1
+            )
+
+            self.assertFalse(result)
+
+    @patch('time.time')
+    def test_wait_for_condition_job_failed_success(self, mock_time):
+        """Test wait_for_condition for a failed job - detects failure"""
+        mock_time.side_effect = [0, 0, 1, 2, 2]
+
+        mock_job = MagicMock()
+        mock_job.status.completion_time = None
+        mock_job.status.succeeded = 0
+        mock_job.status.failed = 3
+        mock_job.status.active = 0
+        mock_job.status.conditions = None
+
+        with patch.object(self.client, 'app') as mock_app, \
+             patch('time.sleep'):
+            mock_app.read_namespaced_job.return_value = mock_job
+
+            result = self.client.wait_for_condition(
+                resource_type="job",
+                resource_name="test-job",
+                wait_condition_type="failed",
+                namespace="test-namespace",
+                timeout_seconds=5
+            )
+
+            self.assertTrue(result)
+
+    @patch('time.time')
+    def test_wait_for_condition_all_jobs_complete(self, mock_time):
+        """Test wait_for_condition for all jobs in a namespace - all complete"""
+        mock_time.side_effect = [0, 0, 1, 2, 2]
+
+        mock_job1 = MagicMock()
+        mock_job1.status.completion_time = "2026-04-20T00:00:00Z"
+        mock_job1.status.succeeded = 1
+        mock_job1.status.failed = None
+        mock_job1.status.active = None
+        mock_job1.status.conditions = None
+
+        mock_job2 = MagicMock()
+        mock_job2.status.completion_time = "2026-04-20T00:01:00Z"
+        mock_job2.status.succeeded = 2
+        mock_job2.status.failed = None
+        mock_job2.status.active = None
+        mock_job2.status.conditions = None
+
+        with patch.object(self.client, 'app') as mock_app, \
+             patch('time.sleep'):
+            mock_app.list_namespaced_job.return_value.items = [mock_job1, mock_job2]
+
+            result = self.client.wait_for_condition(
+                resource_type="job",
+                resource_name=None,
+                wait_condition_type="complete",
+                namespace="test-namespace",
+                timeout_seconds=5,
+                wait_all=True
+            )
+
+            self.assertTrue(result)
+            mock_app.list_namespaced_job.assert_called_with(namespace="test-namespace")
+
+    @patch('time.time')
+    def test_wait_for_condition_job_not_found(self, mock_time):
+        """Test wait_for_condition for a job that doesn't exist - times out"""
+        mock_time.side_effect = [0, 0, 2, 5, 6, 6]
+
+        api_exception = ApiException(status=404, reason="Not Found")
+
+        with patch.object(self.client, 'app') as mock_app, \
+             patch('time.sleep'):
+            mock_app.read_namespaced_job.side_effect = api_exception
+
+            result = self.client.wait_for_condition(
+                resource_type="job",
+                resource_name="nonexistent-job",
+                wait_condition_type="complete",
+                namespace="test-namespace",
+                timeout_seconds=1
+            )
+
+            self.assertFalse(result)
+
+    def test_wait_for_condition_job_invalid_condition(self):
+        """Test wait_for_condition with invalid condition for job resource"""
+        with self.assertRaises(ValueError) as context:
+            self.client.wait_for_condition(
+                resource_type="job",
+                resource_name="test-job",
+                wait_condition_type="available",
+                namespace="test-namespace",
+                timeout_seconds=1
+            )
+
+        self.assertIn("Invalid condition 'available' for resource type 'job'", str(context.exception))
+        self.assertIn("Valid conditions: complete, failed", str(context.exception))
+
     # Tests for the enhanced apply_manifest_from_file method with folder support
     @patch('os.path.isdir')
     @patch('os.path.isfile')