Skip to content

Add cluster automatic MachineAPI header benchmark#1250

Open
karenychen wants to merge 2 commits into
mainfrom
codex/automatic-australiaeast-machineapi-header
Open

Add cluster automatic MachineAPI header benchmark#1250
karenychen wants to merge 2 commits into
mainfrom
codex/automatic-australiaeast-machineapi-header

Conversation

@karenychen

Copy link
Copy Markdown
Contributor

Summary

  • add a 3:00 AM daily MachineAPI variant to the cluster automatic single-cluster benchmark
  • add bootstrappingclient custom feature headers to the existing cluster automatic terraform inputs
  • add MachineAPI terraform inputs with aksmachineapiheaderbatch and matching terraform test inputs

Validation

  • yamllint -c .yamllint pipelines/perf-eval/Automatic\ Benchmark/cluster-automatic-single-cluster.yml --no-warnings
  • terraform fmt -check -diff scenarios/perf-eval/cluster-automatic/terraform-inputs/azure.tfvars scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-automatic-benchmark-acn-on.tfvars scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-machineapi.tfvars scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-automatic-benchmark-acn-on-machineapi.tfvars
  • jq . scenarios/perf-eval/cluster-automatic/terraform-test-inputs/azure-machineapi.json scenarios/perf-eval/cluster-automatic/terraform-test-inputs/azure-automatic-benchmark-acn-on-machineapi.json
  • local assertions for header values and schedule/stage gating

Test run

  • Preparing a New Pipeline Test run on feat/k8s-cluster-crud-machine after PR creation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new MachineAPI variant to the existing cluster-automatic perf-eval benchmark by introducing new Terraform inputs/test inputs and a dedicated daily schedule + stages in the Azure DevOps pipeline.

Changes:

  • Added a new 3:00 AM daily scheduled run path for the MachineAPI variant, with dedicated stages and Terraform inputs.
  • Added aks-custom-headers to existing cluster-automatic Azure Terraform inputs and introduced MachineAPI-specific Terraform inputs.
  • Added Terraform test-input JSON files corresponding to the new MachineAPI .tfvars inputs for validation workflows.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scenarios/perf-eval/cluster-automatic/terraform-test-inputs/azure-machineapi.json Adds Terraform validation test input for the MachineAPI Azure tfvars variant.
scenarios/perf-eval/cluster-automatic/terraform-test-inputs/azure-automatic-benchmark-acn-on-machineapi.json Adds Terraform validation test input for the ACN-on + MachineAPI Azure tfvars variant.
scenarios/perf-eval/cluster-automatic/terraform-inputs/azure.tfvars Adds aks-custom-headers for bootstrappingclient to existing baseline Azure input.
scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-automatic-benchmark-acn-on.tfvars Adds aks-custom-headers for bootstrappingclient to the ACN-on Azure input.
scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-machineapi.tfvars Introduces a new MachineAPI Azure input with MachineAPI-specific header.
scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-automatic-benchmark-acn-on-machineapi.tfvars Introduces a new ACN-on + MachineAPI Azure input with MachineAPI-specific header.
pipelines/perf-eval/Automatic Benchmark/cluster-automatic-single-cluster.yml Adds a MachineAPI daily schedule and new MachineAPI stages, plus stage gating by schedule display name.

Comment on lines +13 to +15
# AKS Automatic MachineAPI On-Demand Schedule
- cron: "0 3 * * *"
displayName: "3:00 AM Daily MachineAPI"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants