Add cluster automatic MachineAPI header benchmark#1250
Open
karenychen wants to merge 2 commits into
Open
Conversation
karenychen
requested review from
LeonardCareer,
alyssa1303,
anson627,
liyu-ma,
sumanthreddy29,
vittoriasalim,
wonderyl and
xinWeiWei24
as code owners
July 9, 2026 23:57
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new MachineAPI variant to the existing cluster-automatic perf-eval benchmark by introducing new Terraform inputs/test inputs and a dedicated daily schedule + stages in the Azure DevOps pipeline.
Changes:
- Added a new 3:00 AM daily scheduled run path for the MachineAPI variant, with dedicated stages and Terraform inputs.
- Added
aks-custom-headersto existing cluster-automatic Azure Terraform inputs and introduced MachineAPI-specific Terraform inputs. - Added Terraform test-input JSON files corresponding to the new MachineAPI
.tfvarsinputs for validation workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scenarios/perf-eval/cluster-automatic/terraform-test-inputs/azure-machineapi.json | Adds Terraform validation test input for the MachineAPI Azure tfvars variant. |
| scenarios/perf-eval/cluster-automatic/terraform-test-inputs/azure-automatic-benchmark-acn-on-machineapi.json | Adds Terraform validation test input for the ACN-on + MachineAPI Azure tfvars variant. |
| scenarios/perf-eval/cluster-automatic/terraform-inputs/azure.tfvars | Adds aks-custom-headers for bootstrappingclient to existing baseline Azure input. |
| scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-automatic-benchmark-acn-on.tfvars | Adds aks-custom-headers for bootstrappingclient to the ACN-on Azure input. |
| scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-machineapi.tfvars | Introduces a new MachineAPI Azure input with MachineAPI-specific header. |
| scenarios/perf-eval/cluster-automatic/terraform-inputs/azure-automatic-benchmark-acn-on-machineapi.tfvars | Introduces a new ACN-on + MachineAPI Azure input with MachineAPI-specific header. |
| pipelines/perf-eval/Automatic Benchmark/cluster-automatic-single-cluster.yml | Adds a MachineAPI daily schedule and new MachineAPI stages, plus stage gating by schedule display name. |
Comment on lines
+13
to
+15
| # AKS Automatic MachineAPI On-Demand Schedule | ||
| - cron: "0 3 * * *" | ||
| displayName: "3:00 AM Daily MachineAPI" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Test run