Fix race condition in ConfigurationManager refresh state (#3142)#3516
Open
dipeshchaudhari3255 wants to merge 1 commit into
Open
Conversation
Store _syncAfter and _lastRequestRefresh as tick values and use Interlocked.Read/Interlocked.Exchange to ensure atomic access. This prevents concurrent callers from observing torn timestamp state and reduces duplicate metadata retrievals under load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race condition in ConfigurationManager refresh state (#3142)
Summary of the changes
Fix race condition caused by non-atomic refresh timestamp access.
Description
Issue #3142 reports a thread-safety concern around concurrent access to refresh timing state in
ConfigurationManager.The fields
_syncAfterand_lastRequestRefreshwere used by multiple threads to determine whether a configuration refresh was required. These values were accessed concurrently without atomic read/write operations, which could result in inconsistent observations under heavy concurrency and lead to duplicate metadata retrievals.Changes
_syncAfteraslongticks._lastRequestRefreshaslongticks.Interlocked.Read.Interlocked.Exchange.Validation
The issue was reproduced using a test application that generated 50 concurrent refresh requests.
Before the fix:
After the fix:
This confirms that concurrent refresh requests no longer trigger multiple simultaneous metadata retrievals.
Fixes #3142