Fix missing else keyword in JwtSecurityTokenHandler key resolution#3518
Open
fre-berhane wants to merge 1 commit into
Open
Fix missing else keyword in JwtSecurityTokenHandler key resolution#3518fre-berhane wants to merge 1 commit into
fre-berhane wants to merge 1 commit into
Conversation
Add missing 'else' at JwtSecurityTokenHandler.cs:1384 so that IssuerSigningKeyResolverUsingConfiguration takes priority over IssuerSigningKeyResolver and default kid-based resolution, matching the documented contract and the correct behavior already present in JsonWebTokenHandler. Without this fix, default key resolution silently overwrites the keys returned by IssuerSigningKeyResolverUsingConfiguration when IssuerSigningKeyResolver is null, defeating key-restriction, key-revocation, and scope-gated key-selection policies.
cpp11nullptr
approved these changes
Jun 2, 2026
iNinja
approved these changes
Jun 2, 2026
pmaytak
approved these changes
Jun 2, 2026
pmaytak
reviewed
Jun 2, 2026
| keys = validationParameters.IssuerSigningKeyResolverUsingConfiguration(token, jwtToken, jwtToken.Header.Kid, validationParameters, configuration); | ||
| } | ||
| if (validationParameters.IssuerSigningKeyResolver != null) | ||
| else if (validationParameters.IssuerSigningKeyResolver != null) |
Collaborator
There was a problem hiding this comment.
Does this mean there are missing test cases that need to be added?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing else keyword in JwtSecurityTokenHandler key resolution
Summary of the changes (Less than 80 chars)
Description
Add missing 'else' at JwtSecurityTokenHandler.cs:1384 so that IssuerSigningKeyResolverUsingConfiguration takes priority over IssuerSigningKeyResolver and default kid-based resolution, matching the documented contract and the correct behavior already present in JsonWebTokenHandler.
Fixes #{bug number} (in this specific format)