User/mstannah/ nouser should not disable IWA authmode (#155)

* Enable IWA for Non interactive auth

* Adding a period

* Uuse IWA only on windows

* Remove platform specific condition

* Combined auth mode return platform specific auth mode

* Updating platform specific test case

* log warnings specific to platform

* Removing the platform win attributes

Author: melindajohnson

src/AzureAuth.Test/CommandMainTest.cs

@@ -725,29 +725,57 @@ public void TestGenerateEvent_From_AuthFlowResult_With_TokenResult_And_Null_Erro
         [TestCase("non-empty-string", false)]
         [TestCase("true", false)]
         [TestCase("", false)]
-        public void TestPCA_IsDisabledOnCorextEnvVar(string corextNonInteractive, bool expected)
+        public void InteractiveAuth_IsDisabledOnCorextEnvVar(string corextNonInteractive, bool expected)
         {
             CommandMain subject = this.serviceProvider.GetService<CommandMain>();
             this.envMock.Setup(e => e.Get("Corext_NonInteractive")).Returns(corextNonInteractive);
-            subject.PCADisabled().Should().Be(expected);
+            subject.InteractiveAuthDisabled().Should().Be(expected);
         }
 
         [TestCase("1", true)]
         [TestCase("non-empty-string", true)]
         [TestCase("true", true)]
         [TestCase("", false)]
-        public void TestPCA_IsDisabledOnNoUserEnvVar(string noUser, bool expected)
+        public void InteractiveAuth_IsDisabledOnNoUserEnvVar(string noUser, bool expected)
         {
             CommandMain subject = this.serviceProvider.GetService<CommandMain>();
             this.envMock.Setup(e => e.Get("AZUREAUTH_NO_USER")).Returns(noUser);
-            subject.PCADisabled().Should().Be(expected);
+            subject.InteractiveAuthDisabled().Should().Be(expected);
         }
 
         [Test]
-        public void PCA_IsEnabledIfEnvVarsAreNotSet()
+        public void InteractiveAuth_IsEnabledIfEnvVarsAreNotSet()
         {
             CommandMain subject = this.serviceProvider.GetService<CommandMain>();
-            subject.PCADisabled().Should().BeFalse();
+            subject.InteractiveAuthDisabled().Should().BeFalse();
+        }
+
+#if PlatformWindows
+        [TestCase("non-empty-string")]
+        public void GetCombinedAuthMode_withInteractiveAuthDisabled(string noUser)
+        {
+            CommandMain subject = this.serviceProvider.GetService<CommandMain>();
+            this.envMock.Setup(e => e.Get("AZUREAUTH_NO_USER")).Returns(noUser);
+            subject.CombinedAuthMode.Should().Be(AuthMode.IWA);
+        }
+
+        public void GetCombinedAuthMode_withInteractiveAuthEnabled()
+        {
+            CommandMain subject = this.serviceProvider.GetService<CommandMain>();
+            var authModes = new List<AuthMode>();
+            authModes.Add(AuthMode.Broker);
+            subject.AuthModes = authModes;
+            subject.CombinedAuthMode.Should().Be(AuthMode.Broker);
+        }
+#endif
+
+        public void GetCombinedAuthMode_withInteractiveAuthEnabled_NonWindowsPlatform()
+        {
+            CommandMain subject = this.serviceProvider.GetService<CommandMain>();
+            var authModes = new List<AuthMode>();
+            authModes.Add(AuthMode.Web);
+            subject.AuthModes = authModes;
+            subject.CombinedAuthMode.Should().Be(AuthMode.Web);
         }
 
         /// <summary>

src/AzureAuth/CommandMain.cs

@@ -217,7 +217,25 @@ public Alias TokenFetcherOptions
             get { return this.authSettings; }
         }
 
-        private AuthMode CombinedAuthMode => this.AuthModes.Aggregate((a1, a2) => a1 | a2);
+        /// <summary>
+        /// Gets the CombinedAuthMode depending on env variables to disable interactive auth modes.
+        /// </summary>
+        public AuthMode CombinedAuthMode
+        {
+            get
+            {
+                if (this.InteractiveAuthDisabled())
+                {
+#if PlatformWindows
+                    return AuthMode.IWA;
+#else
+                    return 0;
+#endif
+                }
+
+                return this.AuthModes.Aggregate((a1, a2) => a1 | a2);
+            }
+        }
 
         /// <summary>
         /// Combine the <see cref="PromptHintPrefix"/> with the caller provided prompt hint.
@@ -359,11 +377,14 @@ public int OnExecute()
             // Small bug in Lasso - Add does not accept a null IEnumerable here.
             this.eventData.Add("settings_scopes", this.authSettings.Scopes ?? new List<string>());
 
-            if (this.PCADisabled())
+            if (this.InteractiveAuthDisabled())
             {
-                this.eventData.Add("no_user", true);
-                this.logger.LogCritical($"User based authentication is disabled");
-                return 1;
+                this.eventData.Add(EnvVars.CorextNonInteractive, this.env.Get(EnvVars.CorextNonInteractive));
+                this.eventData.Add(EnvVars.NoUser, this.env.Get(EnvVars.NoUser));
+                this.logger.LogWarning($"Interactive authentication is disabled.");
+#if PlatformWindows
+                this.logger.LogWarning($"Supported auth mode is Integrated Windows Authentication");
+#endif
             }
 
             return this.ClearCache ? this.ClearLocalCache() : this.GetToken();
@@ -373,7 +394,7 @@ public int OnExecute()
         /// Determines whether Public Client Authentication (PCA) is disabled or not.
         /// </summary>
         /// <returns>A boolean to indicate PCA is disabled.</returns>
-        public bool PCADisabled()
+        public bool InteractiveAuthDisabled()
         {
             return !string.IsNullOrEmpty(this.env.Get(EnvVars.NoUser)) ||
                 string.Equals("1", this.env.Get(EnvVars.CorextNonInteractive));