Extract "clientdata" query parameter name to ClientDataInfo.CLIENTDATA_QUERY_PARAMETER constant

Agent-Logs-Url: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/sessions/5872085e-2412-4653-a01e-bb21157f8983

Co-authored-by: fadidurah <88730756+fadidurah@users.noreply.github.com>

Author: Copilot

common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/microsoftsts/MicrosoftStsAuthorizationResultFactory.java

@@ -73,7 +73,7 @@ protected MicrosoftStsAuthorizationResult parseRedirectUriAndCreateAuthorization
 
         final Map<String, String> urlParameters = UrlUtil.getParameters(redirectUri);
 
-        final ClientDataInfo clientDataInfo = ClientDataInfo.fromPipeDelimited(urlParameters.get("clientdata"));
+        final ClientDataInfo clientDataInfo = ClientDataInfo.fromPipeDelimited(urlParameters.get(ClientDataInfo.CLIENTDATA_QUERY_PARAMETER));
         if (null != clientDataInfo) {
             clientDataInfo.emitToSpan();
         }

common4j/src/main/com/microsoft/identity/common/java/telemetry/ClientDataInfo.java

@@ -49,6 +49,13 @@ public class ClientDataInfo {
     /** Maximum length for any individual field when emitting to a span. */
     private static final int MAX_FIELD_LENGTH = 256;
 
+    /**
+     * The name of the {@code clientdata} query parameter added to /authorize redirect URIs
+     * by eSTS/MSA when {@code clidata=1} is included in the authorization request.
+     * Use this constant everywhere the parameter name is referenced to avoid typos.
+     */
+    public static final String CLIENTDATA_QUERY_PARAMETER = "clientdata";
+
     /** Account type value for MSA accounts. */
     private static final String ACCOUNT_TYPE_MSA_RAW = "m";
 

common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/microsoftsts/MicrosoftStsAuthorizationResultFactoryTest.java

@@ -32,6 +32,7 @@
 import com.microsoft.identity.common.java.providers.oauth2.AuthorizationResult;
 import com.microsoft.identity.common.java.providers.oauth2.AuthorizationResultFactory;
 import com.microsoft.identity.common.java.providers.oauth2.AuthorizationStatus;
+import com.microsoft.identity.common.java.telemetry.ClientDataInfo;
 
 import org.junit.Assert;
 import org.junit.Before;
@@ -295,7 +296,7 @@ public void testClientDataParam_attributesEmitted() {
         // Pipe-delimited format: account_type|error|sub_error|caller_data_boundary|cloud_instance
         final String redirectUrl = MOCK_REDIRECT_URI
                 + "?code=auth_code&state=" + MOCK_STATE_ENCODED
-                + "&clientdata=m%7CAADSTS50058%7Clogin_required%7Cus%7Cpublic";
+                + "&" + ClientDataInfo.CLIENTDATA_QUERY_PARAMETER + "=m%7CAADSTS50058%7Clogin_required%7Cus%7Cpublic";
 
         final Span mockSpan = mock(Span.class);
         when(mockSpan.setAttribute(Mockito.anyString(), Mockito.anyString())).thenReturn(mockSpan);