refactor: rename flight from ESTS_RETURN_REDIRECT to ESTS_HOST_REDIRECT

The feature applies to any eSTS cloud host navigation, not just
return-from-external redirects. Rename the flight constant, string key,
and Javadoc to reflect the actual behavior.

Author: somalaya

common/src/main/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java

@@ -366,7 +366,7 @@ else if (isRedirectUrl(formattedURL)) {
             } else if (CommonFlightsManager.INSTANCE.getFlightsProvider().isFlightEnabled(CommonFlight.ENABLE_ATTACH_PRT_HEADER_WHEN_CROSS_CLOUD) && isCrossCloudRedirect(formattedURL)) {
                 Logger.info(methodTag,"Navigation contains cross cloud redirect.");
                 processCrossCloudRedirect(view, url);
-            } else if (CommonFlightsManager.INSTANCE.getFlightsProvider().isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_RETURN_REDIRECT)
+            } else if (CommonFlightsManager.INSTANCE.getFlightsProvider().isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_HOST_REDIRECT)
                     && isEstsCloudHost(url)
                     && hasPrtHeaderAttached()) {
                 Logger.info(methodTag, "Navigation redirects to eSTS cloud host, re-attaching PRT header.");

common/src/test/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClientEstsHostRedirectTest.java

@@ -134,7 +134,7 @@ public void isEstsCloudHost_returnsFalse_forMalformedUrl() {
     @Test
     public void handleUrl_whenFlightEnabled_andEstsHost_returnsTrue() {
         final IFlightsProvider mockFlightsProvider = Mockito.mock(IFlightsProvider.class);
-        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_RETURN_REDIRECT))
+        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_HOST_REDIRECT))
                 .thenReturn(true);
         // Keep other flights at default behaviour — not enabled
         final MockCommonFlightsManager mockCommonFlightsManager = new MockCommonFlightsManager();
@@ -149,7 +149,7 @@ public void handleUrl_whenFlightEnabled_andEstsHost_returnsTrue() {
     @Test
     public void handleUrl_whenFlightDisabled_andEstsHost_doesNotCallProcessEstsHostRedirect() {
         final IFlightsProvider mockFlightsProvider = Mockito.mock(IFlightsProvider.class);
-        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_RETURN_REDIRECT))
+        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_HOST_REDIRECT))
                 .thenReturn(false);
         final MockCommonFlightsManager mockCommonFlightsManager = new MockCommonFlightsManager();
         mockCommonFlightsManager.setMockCommonFlightsProvider(mockFlightsProvider);
@@ -165,7 +165,7 @@ public void handleUrl_whenFlightDisabled_andEstsHost_doesNotCallProcessEstsHostR
     @Test
     public void handleUrl_whenFlightEnabled_andNonEstsHost_doesNotHandleAsEstsHostRedirect() {
         final IFlightsProvider mockFlightsProvider = Mockito.mock(IFlightsProvider.class);
-        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_RETURN_REDIRECT))
+        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_HOST_REDIRECT))
                 .thenReturn(true);
         final MockCommonFlightsManager mockCommonFlightsManager = new MockCommonFlightsManager();
         mockCommonFlightsManager.setMockCommonFlightsProvider(mockFlightsProvider);
@@ -181,7 +181,7 @@ public void handleUrl_whenFlightEnabled_andNonEstsHost_doesNotHandleAsEstsHostRe
     @Test
     public void handleUrl_whenFlightEnabled_andEstsHost_butNoPrtHeader_doesNotHandleAsEstsHostRedirect() {
         final IFlightsProvider mockFlightsProvider = Mockito.mock(IFlightsProvider.class);
-        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_RETURN_REDIRECT))
+        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_HOST_REDIRECT))
                 .thenReturn(true);
         final MockCommonFlightsManager mockCommonFlightsManager = new MockCommonFlightsManager();
         mockCommonFlightsManager.setMockCommonFlightsProvider(mockFlightsProvider);
@@ -207,7 +207,7 @@ public void setRequestUrl_extractsLoginHint_whenPresent() {
         // an eSTS host, the handler is called (i.e., processEstsHostRedirect
         // was triggered), meaning the URL was handled.
         final IFlightsProvider mockFlightsProvider = Mockito.mock(IFlightsProvider.class);
-        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_RETURN_REDIRECT))
+        when(mockFlightsProvider.isFlightEnabled(CommonFlight.ENABLE_PRT_HEADER_FOR_ESTS_HOST_REDIRECT))
                 .thenReturn(true);
         final MockCommonFlightsManager mockCommonFlightsManager = new MockCommonFlightsManager();
         mockCommonFlightsManager.setMockCommonFlightsProvider(mockFlightsProvider);

common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java

@@ -247,11 +247,10 @@ public enum CommonFlight implements IFlightConfig {
     USE_ENABLED_SETTING_FOR_PACKAGE_CHECK("UseEnabledSettingForPackageCheck", false),
 
     /**
-     * Flight to enable PRT header re-attachment when WebView redirects back to an eSTS cloud host
-     * after visiting an external Entra service domain (e.g. mysignins.microsoft.com).
+     * Flight to enable PRT header re-attachment when WebView navigates to an eSTS cloud host.
      * When enabled, a fresh PRT credential JWT is generated and attached to the request.
      */
-    ENABLE_PRT_HEADER_FOR_ESTS_RETURN_REDIRECT("EnablePrtHeaderForEstsReturnRedirect", false);
+    ENABLE_PRT_HEADER_FOR_ESTS_HOST_REDIRECT("EnablePrtHeaderForEstsHostRedirect", false);
 
     private String key;
     private Object defaultValue;