fixed comments

Author: somalaya

common/src/main/java/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java

@@ -91,6 +91,7 @@
 import static com.microsoft.identity.common.java.AuthenticationConstants.OAuth2.UTID;
 
 import com.microsoft.identity.common.java.opentelemetry.OTelUtility;
+import com.microsoft.identity.common.java.opentelemetry.SpanExtension;
 import com.microsoft.identity.common.java.opentelemetry.SpanName;
 
 import io.opentelemetry.api.trace.Span;
@@ -406,20 +407,27 @@ public boolean onCreateWindow(final WebView view, boolean isDialog,
                 final Span span = OTelUtility.createSpanFromParent(
                         SpanName.WebViewTargetBlankNavigation.name(), parentSpanContext);
                 boolean windowHandled = false;
-                try (final Scope scope = span.makeCurrent()) {
+                try (final Scope scope = SpanExtension.makeCurrentSpan(span)) {
                     Logger.info(methodTag, "onCreateWindow: intercepting target=_blank navigation.");
                     final WebView interceptorWebView = new WebView(view.getContext());
                     interceptorWebView.setWebViewClient(new WebViewClient() {
                         @Override
                         public boolean shouldOverrideUrlLoading(WebView v, WebResourceRequest request) {
                             try {
                                 final String url = request.getUrl().toString();
+                                final String scheme = request.getUrl().getScheme();
+                                if (!"https".equalsIgnoreCase(scheme) && !"http".equalsIgnoreCase(scheme)) {
+                                    Logger.warn(methodTag, "onCreateWindow: ignoring non-http(s) scheme: " + scheme);
+                                    return true;
+                                }
                                 Logger.info(methodTag, "onCreateWindow: opening target=_blank URL in external browser.");
-                                span.setAttribute("target_blank_url", url);
                                 final Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
                                 view.getContext().startActivity(browserIntent);
                             } catch (final Exception e) {
                                 Logger.error(methodTag, "Error opening target=_blank URL in external browser.", e);
+                            } finally {
+                                // Destroy the interceptor WebView after it has served its purpose
+                                v.post(() -> v.destroy());
                             }
                             return true;
                         }
@@ -436,7 +444,8 @@ public boolean shouldOverrideUrlLoading(WebView v, WebResourceRequest request) {
                     windowHandled = true;
                 } catch (@NonNull final Exception e) {
                     Logger.error(methodTag, "Error handling target=_blank navigation.", e);
-                    span.setStatus(StatusCode.ERROR, e.getMessage() != null ? e.getMessage() : "Unknown error");
+                    span.recordException(e);
+                    span.setStatus(StatusCode.ERROR);
                 } finally {
                     span.end();
                 }