Skip to content

Commit 249a5fc

Browse files
authored
Disabling GetCookies API from webapps APIs, Fixes AB#3624552 (#3135)
### Summary We are disabling the GetCookies API as Edge will use getAllSsoTokens instead. There shouldn't be any dependencies here as Edge nor anyone else has actually been calling this API yet. [AB#3624552](https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3624552)
1 parent 3503d1f commit 249a5fc

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

changelog.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ vNext
1818
- [PATCH] Move Multiple Listening apps check to the authorization layer (#3070)
1919
- [MINOR] Add NativeAuthRequestInterceptor for custom per-request headers in native auth flows (#3112)
2020
- [PATCH] Edge TB: Fix lookup mode (#3108)
21+
- [MINOR] Disabling GetCookies API from webapps APIs (#3135)
2122

2223
Version 24.2.0
2324
----------

common4j/src/main/com/microsoft/identity/common/java/commands/webapps/WebAppsSupportedContracts.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,24 +22,24 @@
2222
// THE SOFTWARE.
2323
package com.microsoft.identity.common.java.commands.webapps
2424

25+
import com.microsoft.identity.common.java.util.ObjectMapper
2526
import java.io.Serializable
2627

2728
/**
2829
* Supported contracts for Web Apps Sub Operations
2930
*/
3031
data class WebAppsSupportedContracts(
31-
val contracts: List<String> = listOf(GET_TOKEN, SIGN_OUT, GET_COOKIES)
32+
val contracts: List<String> = listOf(GET_TOKEN, SIGN_OUT)
3233
) : Serializable {
3334
companion object {
3435
const val GET_TOKEN = "GetToken"
3536
const val SIGN_OUT = "SignOut"
37+
// GET_COOKIES contract is currently not needed by Edge (and thus not included in the contracts list),
38+
// but we are keeping the const here for future use if needed.
3639
const val GET_COOKIES = "GetCookies"
3740
}
3841

3942
override fun toString(): String {
40-
return contracts.joinToString(
41-
separator = ", ",
42-
prefix = "[",
43-
postfix = "]")
43+
return ObjectMapper.serializeObjectToJsonString(contracts)
4444
}
4545
}

0 commit comments

Comments
 (0)