Skip to content

Commit 3ae6b1d

Browse files
authored
Merge branch 'dev' into somalaya/VidFixes
2 parents 142bf92 + 8df4e3e commit 3ae6b1d

4 files changed

Lines changed: 63 additions & 0 deletions

File tree

changelog.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Version 24.0.1
1010

1111
Version 24.0.0
1212
----------
13+
- [MINOR] Add Telemetry Constants for browser sso (#2904)
1314
- [MINOR] Add tracking for urls loaded by our webview (#2892)
1415
- [MINOR] Rework OpenTelemetry spans for secret key generation and retrieval operations (#2869)
1516
- [MAJOR] add isBrokerProcess to IPlatformUtil (#2882)

common/src/main/java/com/microsoft/identity/common/internal/apps/AppRegistry.kt

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
package com.microsoft.identity.common.internal.apps
2424

2525

26+
import com.microsoft.identity.common.adal.internal.AuthenticationConstants
2627
import com.microsoft.identity.common.adal.internal.AuthenticationConstants.Broker.INTUNE_AOSP_AGENT_DEBUG_SIGNATURE
2728
import com.microsoft.identity.common.adal.internal.AuthenticationConstants.Broker.INTUNE_AOSP_AGENT_RELEASE_SIGNATURE
2829
import com.microsoft.identity.common.adal.internal.AuthenticationConstants.Broker.ONE_AUTH_TEST_APP_SIGNATURE
@@ -72,6 +73,36 @@ object AppRegistry {
7273
signingCertificateThumbprint = INTUNE_AOSP_AGENT_DEBUG_SIGNATURE
7374
)
7475

76+
val CHROME = App(
77+
nickName = "Google Chrome",
78+
packageName = "com.android.chrome",
79+
signingCertificateThumbprint = "7fmduHKTdHHrlMvldlEqAIlSfii1tl35bxj1OXN5Ve8c4lU6URVu4xtSHc3BVZxS6WWJnxMDhIfQN0N0K2NDJg=="
80+
)
81+
82+
val CHROME_BETA = App(
83+
nickName = "Google Chrome Beta",
84+
packageName = "com.chrome.beta",
85+
signingCertificateThumbprint = "ZZTQrvpldI8bmSdc8TKK3KISErF8zy+nMp269KAuPxyvVz7BqgczKtS90pKGEPV8eVOIRqFDaRe4aDie4lCTpw=="
86+
)
87+
88+
val CHROME_DEV = App(
89+
nickName = "Google Chrome Dev",
90+
packageName = "com.chrome.dev",
91+
signingCertificateThumbprint = "JlOLOTFn6OFBFWuWQJYJ8h/aozEN7/zLFTfioXiXTrU6Yaft4cdEbdpkoJIvmB7GvHpHu6QOz+XIaXybtzL7A=="
92+
)
93+
94+
val CHROME_CANARY = App(
95+
nickName = "Google Chrome Canary",
96+
packageName = "com.chrome.canary",
97+
signingCertificateThumbprint = "QfTWFoLyXuOCZ7bMYlMN+la3J3rau5x8p+w2v7vf1gOPiTyIMgdbNDzLaLWhgiC2ioj/hFqk8oZyqdJbFG6G4g=="
98+
)
99+
100+
val MSAL_TEST_APP = App(
101+
nickName = "MSAL Test App",
102+
packageName = "com.msft.identity.client.sample.local",
103+
signingCertificateThumbprint = AuthenticationConstants.Broker.BROKER_HOST_APP_SIGNATURE_SHA512
104+
)
105+
75106
@JvmField
76107
val SSO_TOKEN_AUTHORIZED_APPS = buildSet {
77108
add(EDGE)
@@ -107,4 +138,19 @@ object AppRegistry {
107138
add(BrokerData.debugIntuneCE)
108139
}
109140
}
141+
142+
/**
143+
* Apps authorized to request Browser SSO headers (PRT credentials).
144+
* Currently limited to Chrome browser variants.
145+
*/
146+
@JvmField
147+
val BROWSER_SSO_AUTHORIZED_APPS = buildSet {
148+
add(CHROME)
149+
add(CHROME_BETA)
150+
add(CHROME_DEV)
151+
add(CHROME_CANARY)
152+
if (BrokerData.getShouldTrustDebugBrokers()) {
153+
add(MSAL_TEST_APP)
154+
}
155+
}
110156
}

common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -515,6 +515,18 @@ public enum AttributeName {
515515
*/
516516
is_redirect_url_opened_in_browser,
517517

518+
/**
519+
* Number of PRT accounts for which SSO token generation succeeded in a Browser SSO request.
520+
* DataClassification: SystemMetadata.
521+
*/
522+
browser_sso_success_count,
523+
524+
/**
525+
* Number of PRT accounts for which SSO token generation failed in a Browser SSO request.
526+
* DataClassification: SystemMetadata.
527+
*/
528+
browser_sso_failure_count,
529+
518530
/**
519531
* Indicates the number of retry attempts made in DRS discovery when the retry policy is enabled.
520532
*/

common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,10 @@ public enum SpanName {
9090
* Span name for web apps API execute requests.
9191
*/
9292
ExecuteWebAppsRequest,
93+
/**
94+
* Span name for the Browser SSO header generation operation.
95+
*/
96+
GetBrowserSsoHeaders,
9397
/**
9498
* Span name for secret key generation operations.
9599
*/

0 commit comments

Comments
 (0)