Skip to content

Commit 906f026

Browse files
authored
Fix MSA login timeout: use configurable timeout for 'Other ways to si…, Fixes AB#3622375 (#3138)
The 'Other ways to sign in' UI element check in handlePasswordField() was hardcoded to FIND_UI_ELEMENT_TIMEOUT_SHORT (10s), which was insufficient for the WebView to load login.live.com through the IPC + network chain. This caused intermittent TimeoutExceptions in MSA broker tests. Changed to use mFindLoginUiElementTimeout (25s default, 30s for NAA tests) which is consistent with other UI element checks in the same handler. Fixes: TestCase2688459 (NAA ATS), TestCase2637829 (MSA Prompt.Login) Fixes [AB#3622375](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3622375)
1 parent 249a5fc commit 906f026

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

uiautomationutilities/src/main/java/com/microsoft/identity/client/ui/automation/interaction/microsoftsts/AadLoginComponentHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public void handlePasswordField(@NonNull final String password, final boolean is
8686
// says "Other ways to sign in"
8787
// 2. No OTP or MFA, just prompted for password right away.
8888
if (isMsaAccount) {
89-
final UiObject otherWays = UiAutomatorUtils.obtainUiObjectWithExactText("Other ways to sign in", CommonUtils.FIND_UI_ELEMENT_TIMEOUT_SHORT);
89+
final UiObject otherWays = UiAutomatorUtils.obtainUiObjectWithExactText("Other ways to sign in", mFindLoginUiElementTimeout);
9090
if (otherWays.exists()) {
9191
try {
9292
otherWays.click();

0 commit comments

Comments
 (0)