Modify IDeviceCertificate, Fixes AB#3235066 (#2647)

[AB#3235066](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3235066)

AzureAD/ad-accounts-for-android#3099

Author: rpdome

common4j/src/main/com/microsoft/identity/common/java/challengehandlers/IDeviceCertificate.java

@@ -53,9 +53,8 @@ public interface IDeviceCertificate {
     /**
      * Signs a piece of data with the (private key associated to the) certificate.
      *
-     * @param algorithm         algorithm for signing the data.
      * @param dataToBeSigned    the data to be signed.
      */
-    byte[] sign(@NonNull final String algorithm, final byte[] dataToBeSigned) throws ClientException;
+    byte[] sign(final byte[] dataToBeSigned) throws ClientException;
 }
 

common4j/src/main/com/microsoft/identity/common/java/util/JWSBuilder.java

@@ -165,7 +165,7 @@ public String generateSignedJWT(@NonNull final String nonce,
                     + "."
                     + encodeUrlSafeString(StringUtil.toByteArray(claimsJsonString));
             signature = encodeUrlSafeString(
-                    deviceCert.sign(SIGNING_ALGORITHM, StringUtil.toByteArray(signingInput)));
+                    deviceCert.sign(StringUtil.toByteArray(signingInput)));
         } catch (final CertificateEncodingException e) {
             throw new ClientException(ErrorStrings.CERTIFICATE_ENCODING_ERROR,
                     "Certificate encoding error", e);

common4j/src/test/com/microsoft/identity/common/java/challengehandlers/MockCertLoader.java

@@ -65,7 +65,7 @@ public boolean isValidIssuer(List<String> certAuthorities) {
         }
 
         @Override
-        public byte[] sign(@NonNull String algorithm, byte[] dataToBeSigned) throws ClientException {
+        public byte[] sign(byte[] dataToBeSigned) throws ClientException {
             throw new UnsupportedOperationException("Should be mocked!");
         }
     };

common4j/src/test/com/microsoft/identity/common/java/util/JwsBuilderTest.java

@@ -175,7 +175,7 @@ public boolean isValidIssuer(List<String> certAuthorities) {
             }
 
             @Override
-            public byte[] sign(@NonNull final String algorithm, final byte[] dataToBeSigned) throws ClientException {
+            public byte[] sign(final byte[] dataToBeSigned) throws ClientException {
                 // Do nothing.
                 return StringUtil.toByteArray(signature);
             }