Skip to content

Commit baae279

Browse files
fadidurahCopilot
andcommitted
common4j: don't tie sourcesJar/javadocJar to assemble
These tasks are already wired into the publish graph through components.java + the maven-publish plugin, so they will be generated automatically when publish runs. Tying them to assemble made every CI flow that just compiles or runs tests also build javadoc, which is one of the slowest tasks in the common4j build. Local developers who want the artifacts can still run ./gradlew sourcesJar javadocJar explicitly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent d98d3e1 commit baae279

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

common4j/build.gradle

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,11 @@ buildConfig {
339339
}
340340

341341
afterEvaluate {
342-
assemble.dependsOn sourcesJar, javadocJar
343-
342+
// sourcesJar and javadocJar are wired into the publish graph via components.java + maven-publish,
343+
// so they will run automatically as part of `publish`. There is no need to also tie them to
344+
// `assemble`, which made every CI build (including test-only / spotbugs-only flows) generate
345+
// javadoc unnecessarily. Generating javadoc for common4j is one of the slower tasks in the build.
346+
// Local devs who explicitly want the artifacts can still run `./gradlew sourcesJar javadocJar`.
344347
// these tasks are generated by the buildconfig plugin..for more details, read comment about it
345348
// above in the plugins block.
346349
compileJava.dependsOn generateBuildConfig, generateTestBuildConfig

0 commit comments

Comments
 (0)