nits

Author: jeffrymsft

common/build.gradle

@@ -116,10 +116,6 @@ android {
         dist {
             dimension "main"
         }
-        production{
-            dimension "main"
-            matchingFallbacks = ['dist']
-        }
     }
 
     sourceSets {
@@ -256,7 +252,6 @@ android.libraryVariants.all { variant ->
 
 tasks.register('sourcesJar', Jar) {
     from android.sourceSets.main.java.srcDirs
-//    classifier 'sources'
     archiveClassifier.set('sources')
     destinationDirectory = reporting.file("$project.buildDir/outputs/jar/")
 }
@@ -305,8 +300,6 @@ afterEvaluate {
         publications {
             distRelease(MavenPublication) {
                 from components.distRelease
-                println "Components1: ${components.distRelease}"
-                println "pname: ${project.name}"
                 groupId 'com.microsoft.identity'
                 artifactId 'common'
                 //Edit the 'version' here for VSTS RC build
@@ -343,16 +336,11 @@ afterEvaluate {
             }
             distDebug(MavenPublication) {
                 from components.distDebug
-                println "Components2: ${components.distDebug}"
-                println "pname: ${project.name}"
-
-//                withoutComponent()
                 groupId 'com.microsoft.identity'
                 artifactId 'common-debug'
                 //Edit the 'version' here for VSTS RC build
 
                 version = project.version
-//                artifact{"$buildDir/outputs/aar/common-debug-${project.version}.aar"}
             }
         }
 
@@ -406,7 +394,6 @@ tasks.withType(GenerateMavenPom).all {
     } else if (name.contains("distRelease")) {
         destination = layout.buildDirectory.file("poms/common-${project.version}.pom").get().asFile
     }
-//    destination = layout.buildDirectory.file("poms/${project.name}-${project.version}.pom").get().asFile
 }
 
 def dependenciesSizeInMb = project.hasProperty("dependenciesSizeMb") ? project.dependenciesSizeMb : "15"

common/src/main/java/com/microsoft/identity/common/internal/broker/MicrosoftAuthClient.java

@@ -39,7 +39,6 @@
 
 import static com.microsoft.identity.common.adal.internal.AuthenticationConstants.Broker.BROKER_ACTIVITY_NAME;
 import static com.microsoft.identity.common.adal.internal.AuthenticationConstants.Broker.BROKER_PACKAGE_NAME;
-//import static com.microsoft.identity.common.adal.internal.AuthenticationConstants.BrokerContentProvider.API.MSAL_HELLO;
 import static com.microsoft.identity.common.exception.BrokerCommunicationException.Category.OPERATION_NOT_SUPPORTED_ON_CLIENT_SIDE;
 import static com.microsoft.identity.common.internal.broker.ipc.IIpcStrategy.Type.BOUND_SERVICE;
 

common/src/main/java/com/microsoft/identity/common/sharedwithoneauth/OneAuthSharedFunctions.kt

@@ -24,12 +24,8 @@ package com.microsoft.identity.common.sharedwithoneauth
 
 import android.content.Context
 import androidx.annotation.WorkerThread
-
 import android.os.IInterface
-
-
 import com.microsoft.identity.common.components.AndroidPlatformComponentsFactory
-import com.microsoft.identity.common.internal.broker.BoundServiceClient
 import com.microsoft.identity.common.internal.broker.MicrosoftAuthClient
 import com.microsoft.identity.common.internal.broker.ipc.AccountManagerAddAccountStrategy
 import com.microsoft.identity.common.internal.broker.ipc.BoundServiceStrategy
@@ -86,8 +82,8 @@ class OneAuthSharedFunctions {
                 sb.append("ContentProviderStrategy, ")
                 strategies.add(contentProviderStrategy)
             }
-            val boundServiceStrategy = BoundServiceStrategy(MicrosoftAuthClient(context))
 
+            val boundServiceStrategy = BoundServiceStrategy(MicrosoftAuthClient(context))
             if (boundServiceStrategy.isSupportedByTargetedBroker(activeBrokerPackageName)) {
                 sb.append("BoundServiceStrategy, ")
                 strategies.add(boundServiceStrategy)

common4j/build.gradle

@@ -71,7 +71,6 @@ task sourcesJar(type: Jar) {
 task generateJavadoc(type: Javadoc) {
     dependsOn generateBuildConfig
     failOnError false
-    dependsOn
     title = "Microsoft Identity Common Java"
     source = sourceSets.main.java
     classpath += project.sourceSets.main.compileClasspath

testutils/build.gradle

@@ -101,7 +101,6 @@ android {
 
 task sourcesJar(type: Jar) {
     from android.sourceSets.main.java.srcDirs
-//    classifier 'sources'
     archiveClassifier.set('sources')
 }
 

uiautomationutilities/build.gradle

@@ -150,7 +150,6 @@ android {
 
 task sourcesJar(type: Jar) {
     from android.sourceSets.main.java.srcDirs
-//    classifier 'sources'
     archiveClassifier.set('sources')
 }