Address review comments on PR #3121

- Use {@code lastLoadedDomain} in javadoc instead of markdown backticks
- Emit STEP_BROKER_INSTALL_PROMPTED from processPlayStoreURL and
  processPlayStoreURLForBrokerApps so Play Store dispatch paths populate
  the onboarding step timeline (previously only processInstallRequest and
  processIntentToInstallBrokerApp did)
- Test: use OnboardingTelemetryConstants.STEP_BROKER_INSTALL_PROMPTED and
  LAST_LOADED_DOMAIN constants instead of hardcoded string literals
- Test: clear OnboardingSessionCorrelationStore in @after teardown to keep
  tests isolated from other onboarding tests

Author: wzhipan

common/src/main/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java

@@ -159,7 +159,7 @@ public class AzureActiveDirectoryWebViewClient extends OAuth2WebViewClient {
      * after this client is constructed (the recorder is created by the host fragment/activity
      * when a seed JSON arrives, which is typically later than WebView construction).
      * When non-null, key URL transitions (broker install, MDM enrollment, Company Portal
-     * launch, etc.) and `lastLoadedDomain` are recorded for the onboarding telemetry blob.
+     * launch, etc.) and {@code lastLoadedDomain} are recorded for the onboarding telemetry blob.
      */
     @Nullable
     private com.microsoft.identity.common.internal.telemetry.OnboardingTelemetryRecorder mOnboardingTelemetryRecorder;
@@ -917,6 +917,7 @@ private boolean processPlayStoreURL(@NonNull final WebView view, @NonNull final
         }
         final String appPackageName = getBrokerAppPackageNameFromUrl(url);
         Logger.info(methodTag, "Request to open PlayStore to install package : '" + appPackageName + "'");
+        recordOnboardingStep(com.microsoft.identity.common.java.telemetry.OnboardingTelemetryConstants.STEP_BROKER_INSTALL_PROMPTED);
 
         try {
             final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(PLAY_STORE_INSTALL_PREFIX + appPackageName));
@@ -936,6 +937,7 @@ private boolean processPlayStoreURLForBrokerApps(@NonNull final WebView view, @N
 
         final String appPackageName = getBrokerAppPackageNameFromUrl(url);
         Logger.info(methodTag, "Request to open PlayStore to install package : '" + appPackageName + "'");
+        recordOnboardingStep(com.microsoft.identity.common.java.telemetry.OnboardingTelemetryConstants.STEP_BROKER_INSTALL_PROMPTED);
 
         try {
             final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(PLAY_STORE_INSTALL_APP_PREFIX + appPackageName));

common/src/test/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClientTest.java

@@ -183,6 +183,12 @@ public void onPageLoaded(final String url) {
     @After
     public void cleanUp(){
         CommonFlightsManager.INSTANCE.resetFlightsManager();
+        // Clear onboarding session-correlation SharedPreferences to keep tests isolated;
+        // OnboardingTelemetryRecorder.addBlockingError persists to this store.
+        if (mContext != null) {
+            new com.microsoft.identity.common.internal.telemetry.OnboardingSessionCorrelationStore(mContext)
+                    .save("");
+        }
     }
 
     @Test(expected = IllegalArgumentException.class)
@@ -1128,7 +1134,8 @@ public void testProcessInstallRequest_RecordsBrokerInstallPromptedStep() throws
         final org.json.JSONArray steps = blob.getJSONArray("steps_list");
         boolean foundStep = false;
         for (int i = 0; i < steps.length(); i++) {
-            if ("BrokerInstallPrompted".equals(steps.getJSONObject(i).getString("step_id"))) {
+            if (com.microsoft.identity.common.java.telemetry.OnboardingTelemetryConstants
+                    .STEP_BROKER_INSTALL_PROMPTED.equals(steps.getJSONObject(i).getString("step_id"))) {
                 foundStep = true;
                 break;
             }
@@ -1165,7 +1172,8 @@ public void testOnPageFinished_RecordsLastLoadedDomain() throws Exception {
         mWebViewClient.onPageFinished(mMockWebView, "https://login.microsoftonline.com/common/oauth2/authorize");
 
         final org.json.JSONObject blob = new org.json.JSONObject(recorder.finalizeBlob());
-        assertEquals("login.microsoftonline.com", blob.getString("last_loaded_domain"));
+        assertEquals("login.microsoftonline.com", blob.getString(
+                com.microsoft.identity.common.java.telemetry.OnboardingTelemetryConstants.LAST_LOADED_DOMAIN));
     }
 
     /**