Commit cd914e4
Rename SovSG → GovSG in Common module, Fixes AB#3565148 (#3068)
The Singapore sovereign cloud was incorrectly named "SovSG" — the
correct branding is "GovSG". This is a pure identifier rename; the
hostname `login.sovcloud-identity.sg` is unchanged.
### Production code
- **`AzureActiveDirectoryCloud.java`**: `SOVSG_CLOUD_HOST` →
`GOVSG_CLOUD_HOST`, `SOVSG` → `GOVSG`, JavaDoc updated
- **`AzureActiveDirectory.java`**: import, `KNOWN_CLOUD_DISCOVERY_HOSTS`
entry, and `preSeedSovereignClouds()` reference updated
### Tests
- `AzureActiveDirectoryCloudTest.kt` — test functions, local variable
`sovsg` → `govsg`, all constant references
- `AzureActiveDirectoryTest.kt` — `testIsKnownCloudDiscoveryHost_sovsg`
→ `_govsg`
- `AzureActiveDirectoryAuthorityCloudTest.kt` — three test functions and
local variables renamed
- `AuthorityKnownAuthorityTest.kt` — comment and test function renamed
### Changelog
- Added a `[PATCH]` entry to `changelog.txt` under `vNext` noting the
rename.
<!-- START COPILOT CODING AGENT SUFFIX -->
<!-- START COPILOT ORIGINAL PROMPT -->
<details>
<summary>Original prompt</summary>
> ## Rename SovSG to GovSG in Common module
>
> Fixes
[AB#3565148](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3565148)
>
> ### Objective
> Rename all occurrences of **SovSG** to **GovSG** in the Common module.
The Singapore sovereign cloud was incorrectly named "SovSG" — the
correct term is "GovSG".
>
> ### Context
> The sovereign cloud constants and instances in
`AzureActiveDirectoryCloud.java` use the incorrect abbreviation "SovSG"
for the Singapore sovereign cloud. This needs to be corrected to "GovSG"
across all production code and associated tests. The actual hostname
`login.sovcloud-identity.sg` is correct and must NOT be changed.
>
> ### Technical Requirements
>
> #### 1. AzureActiveDirectoryCloud.java
> Path:
`common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloud.java`
> - Rename constant `SOVSG_CLOUD_HOST` to `GOVSG_CLOUD_HOST` (line 127).
The string value `"login.sovcloud-identity.sg"` must NOT change.
> - Update JavaDoc comment: `SovSG sovereign cloud` to `GovSG sovereign
cloud` (line 144)
> - Rename static instance `SOVSG` to `GOVSG` (line 145)
> - Update all references to `SOVSG_CLOUD_HOST` within the instance
constructor call (lines 146-148) to `GOVSG_CLOUD_HOST`
>
> #### 2. AzureActiveDirectory.java
> Path:
`common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectory.java`
> - Rename import: `import static
...AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST` to `GOVSG_CLOUD_HOST`
(line 31)
> - Rename usage in `KNOWN_CLOUD_DISCOVERY_HOSTS` set:
`SOVSG_CLOUD_HOST` to `GOVSG_CLOUD_HOST` (line 119)
> - Rename usage in `preSeedSovereignClouds()`:
`AzureActiveDirectoryCloud.SOVSG` to `AzureActiveDirectoryCloud.GOVSG`
(line 137)
>
> #### 3. AzureActiveDirectoryCloudTest.kt
> Path:
`common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloudTest.kt`
> - Rename test function `testSovsgCloudHostConstant()` to
`testGovsgCloudHostConstant()`
> - Update reference `AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST` to
`AzureActiveDirectoryCloud.GOVSG_CLOUD_HOST`
> - Rename test function `testSovsgCloudInstance()` to
`testGovsgCloudInstance()`
> - Rename local variable `val sovsg` to `val govsg` and all its usages
> - Update all `AzureActiveDirectoryCloud.SOVSG` to
`AzureActiveDirectoryCloud.GOVSG`
> - Update all `AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST` to
`AzureActiveDirectoryCloud.GOVSG_CLOUD_HOST`
>
> #### 4. AzureActiveDirectoryTest.kt
> Path:
`common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryTest.kt`
> - Rename test function `testIsKnownCloudDiscoveryHost_sovsg()` to
`testIsKnownCloudDiscoveryHost_govsg()`
>
> #### 5. AzureActiveDirectoryAuthorityCloudTest.kt
> Path:
`common4j/src/test/com/microsoft/identity/common/java/authorities/AzureActiveDirectoryAuthorityCloudTest.kt`
> - Rename test functions:
`testIsSameCloudAsAuthority_bothSovsg_returnsTrue` to `bothGovsg`,
`bleuVsSovsg` to `bleuVsGovsg`, `delosVsSovsg` to `delosVsGovsg`
> - Rename local variables `val sovsg` to `val govsg` and all usages
> - Update all `SOVSG_CLOUD_HOST` to `GOVSG_CLOUD_HOST`
>
> #### 6. AuthorityKnownAuthorityTest.kt
> Path:
`common4j/src/test/com/microsoft/identity/common/java/authorities/AuthorityKnownAuthorityTest.kt`
> - Update comment: `(SovSG)` to `(GovSG)`
> - Rename test function `testIsKnownAuthority_sovsgSovereignCloud()` to
`testIsKnownAuthority_govsgSovereignCloud()`
> - Update reference `AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST` to
`AzureActiveDirectoryCloud.GOVSG_CLOUD_HOST`
>
> ### Acceptance Criteria
> - All `SOVSG`, `SovSG`, `sovsg`, `Sovsg` identifiers and comments in
common4j are renamed to `GOVSG`, `GovSG`, `govsg`, `Govsg` respectively.
> - The actual hostname string `login.sovcloud-identity.sg` is NOT
changed anywhere.
> - All existing tests pass after the rename (run `./gradlew
:common4j:test`).
> - No logic changes — this is purely a naming fix.
> - Follow .github/copilot-instructions.md strictly.
>
</details>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mohitc1 <22034758+mohitc1@users.noreply.github.com>1 parent 06771b8 commit cd914e4
7 files changed
Lines changed: 36 additions & 35 deletions
File tree
- common4j/src
- main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory
- test/com/microsoft/identity/common/java
- authorities
- providers/microsoft/azureactivedirectory
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| |||
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
149 | 149 | | |
150 | 150 | | |
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
56 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | | - | |
71 | | - | |
| 70 | + | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | | - | |
78 | | - | |
| 77 | + | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
Lines changed: 13 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
| 41 | + | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | | - | |
| 84 | + | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
0 commit comments