add a file for metric names

Author: fadidurah

common/src/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java

@@ -102,6 +102,7 @@
 import com.microsoft.identity.common.java.exception.UnsupportedBrokerException;
 import com.microsoft.identity.common.java.interfaces.IPlatformComponents;
 import com.microsoft.identity.common.java.opentelemetry.OTelUtility;
+import com.microsoft.identity.common.java.opentelemetry.OtelCountMetrics;
 import com.microsoft.identity.common.java.providers.microsoft.MicrosoftRefreshToken;
 import com.microsoft.identity.common.java.providers.microsoft.azureactivedirectory.ClientInfo;
 import com.microsoft.identity.common.java.providers.microsoft.microsoftsts.MicrosoftStsAccount;
@@ -153,10 +154,10 @@ public class BrokerMsalController extends BaseController {
 
     private String mMaxMsalBrokerProtocolVersion;
 
-    // telemetry count metric for tracking getCurrentAccount() SDM failures
-    private static final LongCounter sGetCurrentAccountFailedNoSDMCount = OTelUtility.createLongCounter(
-            "get_current_account_failed_no_sdm_count",
-            "Number of failed getCurrentAccount calls due to no SDM"
+    // telemetry count metric for tracking getCurrentAccount() calls where no SDM is present
+    private static final LongCounter sGetCurrentAccountWithNoSDMCount = OTelUtility.createLongCounter(
+            OtelCountMetrics.get_current_account_with_no_sdm_count.name(),
+            "Number of getCurrentAccount calls with no SDM present"
     );
 
     public BrokerMsalController(@NonNull final Context applicationContext,
@@ -955,7 +956,7 @@ List<ICacheRecord> getCurrentAccount(final @NonNull CommandParameters parameters
 
         if (!parameters.isSharedDevice()) {
             Logger.verbose(TAG + methodName, "Not a shared device, invoke getAccounts() instead of getCurrentAccount()");
-            sGetCurrentAccountFailedNoSDMCount.add(1); // TODO: Any useful attributes? How is this emitted?
+            sGetCurrentAccountWithNoSDMCount.add(1); // TODO: Any useful attributes to add? How is this emitted?
             return getAccounts(parameters);
         }
 

common/src/main/java/com/microsoft/identity/common/internal/util/AndroidKeyStoreUtil.java

@@ -28,6 +28,7 @@
 import com.microsoft.identity.common.java.logging.Logger;
 import com.microsoft.identity.common.java.opentelemetry.AttributeName;
 import com.microsoft.identity.common.java.opentelemetry.OTelUtility;
+import com.microsoft.identity.common.java.opentelemetry.OtelCountMetrics;
 import com.microsoft.identity.common.java.util.ThrowableUtil;
 import com.microsoft.identity.common.java.util.ported.DateUtilities;
 
@@ -94,7 +95,7 @@ private AndroidKeyStoreUtil() {
     }
 
     private static final LongCounter sFailedAndroidKeyStoreUnwrapOperationCount = OTelUtility.createLongCounter(
-            "failed_keystore_key_unwrap_operation_count",
+            OtelCountMetrics.failed_keystore_key_unwrap_operation_count.name(),
             "Number of failed Android KeyStore unwrap operations"
     );
 

common4j/src/main/com/microsoft/identity/common/java/opentelemetry/OtelCountMetrics.kt

@@ -0,0 +1,39 @@
+// Copyright (c) Microsoft Corporation.
+// All rights reserved.
+//
+// This code is licensed under the MIT License.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files(the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and / or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions :
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+package com.microsoft.identity.common.java.opentelemetry
+
+/**
+ * Class containing the names of various Open Telemetry Metrics that we use in our code today, similar to AttributeName.
+ * Creating this to have a central hub for tracking where metrics are used in our code base.
+ */
+enum class OtelCountMetrics {
+    /**
+     * Number of failed Android KeyStore unwrap operations
+     */
+    failed_keystore_key_unwrap_operation_count,
+
+    /**
+     * Number of getCurrentAccount calls with no SDM present
+     */
+    get_current_account_with_no_sdm_count
+}