Skip to content

Commit f1aa8ca

Browse files
mohitc1Mohit
andauthored
Fix test_2828864_DCF_CheckSignInFromOtherDeviceOptionAvailable, Fixes AB#3537345 (#3015)
To fix the failure test_2828864_DCF_CheckSignInFromOtherDeviceOptionAvailable, which currently verifies DCF url. The device URL has changed form microsoft.com/devicelogin to login.microsoft.com/device. The test case is primarily about having an option to "Sign-in in using another device". So, fixing it by just verifying that option is available and can be clicked. Removing the verification to actually check the DCF url to reduce dependency on server UX. There's corresponding MSAL PR as well: AzureAD/microsoft-authentication-library-for-android#2482 Fixes [AB#3537345](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3537345) test passed here: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1604835&view=ms.vss-test-web.build-test-results-tab --------- Co-authored-by: Mohit <mchand@microsoft.com>
1 parent 9c9f6df commit f1aa8ca

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

uiautomationutilities/src/main/java/com/microsoft/identity/client/ui/automation/interaction/microsoftsts/AadLoginComponentHandler.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -278,12 +278,9 @@ public void handleHowWouldYouLikeToSignIn() {
278278
}
279279

280280
@Override
281-
public void handleSignInFromOtherDevice(@NonNull final String expectedDeviceLoginUrl) {
281+
public void handleSignInFromOtherDevice() {
282282
this.handleSignInOptions();
283283
UiAutomatorUtils.handleButtonClickForObjectWithText(SIGN_IN_FROM_OTHER_DEVICE);
284-
285-
// verify the remote device login url is displayed.
286-
Assert.assertTrue(UiAutomatorUtils.obtainUiObjectWithText(expectedDeviceLoginUrl).exists());
287284
}
288285

289286
@Override

uiautomationutilities/src/main/java/com/microsoft/identity/client/ui/automation/interaction/microsoftsts/IMicrosoftStsLoginComponentHandler.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,8 @@ public interface IMicrosoftStsLoginComponentHandler extends IOAuth2LoginComponen
8787

8888
/**
8989
* Handle interaction for "Sign in from other device".
90-
* @param expectedDeviceLoginUrl the expected remote login url when "Sign in from other device" option is
91-
* exercised.
9290
*/
93-
void handleSignInFromOtherDevice(@NonNull final String expectedDeviceLoginUrl);
91+
void handleSignInFromOtherDevice();
9492

9593
/**
9694
* Handle interaction with "Sign in options".

0 commit comments

Comments
 (0)