Skip to content

Change display-mask dependency to compileOnly #2899

@azabost

Description

@azabost

Currently, display-mask is a runtime dependency:

implementation(group: 'com.microsoft.device.display', name: 'display-mask', version: '0.3.0')

This requires adding the appropriate Maven repository to every project using MSAL (as explained in the documentation here)

//Needed for com.microsoft.device.display:display-mask library
maven {
    url 'https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1'
    name 'Duo-SDK-Feed'
}

However, I noticed the DisplayMask class in that JAR file is just a stub.

Image

I assume that the real implementation is provided by the operating system on the relevant devices (Surface Duo?).

Given that, I think the dependency on display-mask could be declared as compileOnly:

compileOnly(group: 'com.microsoft.device.display', name: 'display-mask', version: '0.3.0')

This change would save users the trouble of adding a dedicated Maven repository just for that single dependency.

(Correct me if I'm wrong 🙂 )

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions