Currently, display-mask is a runtime dependency:
|
implementation(group: 'com.microsoft.device.display', name: 'display-mask', version: '0.3.0') |
This requires adding the appropriate Maven repository to every project using MSAL (as explained in the documentation here)
//Needed for com.microsoft.device.display:display-mask library
maven {
url 'https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1'
name 'Duo-SDK-Feed'
}
However, I noticed the DisplayMask class in that JAR file is just a stub.
I assume that the real implementation is provided by the operating system on the relevant devices (Surface Duo?).
Given that, I think the dependency on display-mask could be declared as compileOnly:
compileOnly(group: 'com.microsoft.device.display', name: 'display-mask', version: '0.3.0')
This change would save users the trouble of adding a dedicated Maven repository just for that single dependency.
(Correct me if I'm wrong 🙂 )
Currently,
display-maskis a runtime dependency:microsoft-authentication-library-common-for-android/common/build.gradle
Line 220 in 132e308
This requires adding the appropriate Maven repository to every project using MSAL (as explained in the documentation here)
However, I noticed the
DisplayMaskclass in that JAR file is just a stub.I assume that the real implementation is provided by the operating system on the relevant devices (Surface Duo?).
Given that, I think the dependency on
display-maskcould be declared ascompileOnly:This change would save users the trouble of adding a dedicated Maven repository just for that single dependency.
(Correct me if I'm wrong 🙂 )