DUNA flow: Resume Auth , Fixes AB#3079802#2557
Merged
Conversation
…D/microsoft-authentication-library-common-for-android into pedroro/switch-to-browser
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
shahzaibj
reviewed
Mar 10, 2025
mohitc1
reviewed
Mar 12, 2025
mohitc1
reviewed
Mar 12, 2025
mohitc1
reviewed
Mar 12, 2025
mohitc1
reviewed
Mar 12, 2025
shahzaibj
reviewed
Mar 18, 2025
shahzaibj
reviewed
Mar 18, 2025
shahzaibj
reviewed
Mar 18, 2025
shahzaibj
approved these changes
Mar 18, 2025
p3dr0rv
added a commit
that referenced
this pull request
Mar 24, 2025
Removed this method on this PR #2557 and this broke OneAuth, this is used there https://office.visualstudio.com/OneAuth/_git/OneAuth?path=/msal/source/android/msal/app/src/main/java/com/microsoft/identity/internal/ui/BrowserContainerDialog.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses step 16 of the Switch browser flow
BrokerBrowserRedirectActivity will re-start the WebViewAuthorizationFragment so we update the intent data and handle the activity being resumed on WebViewAuthorizationFragment.onResume
The switch browser resume endpoint requires the client ID, so we need to pass this value at the moment we start the WebAuthorizaFragment.
Refactor AuthorizationActivityFactory to work with one data parameter to create the auth intent.
AB#3079802