Added tests for intercepting cross cloud redirect url scenario , Fixes AB#3179147#2605
Merged
Added tests for intercepting cross cloud redirect url scenario , Fixes AB#3179147#2605
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
somalaya
changed the title
mohitc1
reviewed
Mar 14, 2025
| val testUrl = "https://example.com?login_hint=testuser" | ||
| crossCloudChallengeHandler.processChallenge(testUrl) | ||
| verify(webView).loadUrl(eq(testUrl), eq(headers)) | ||
| } |
Contributor
There was a problem hiding this comment.
Since you already have test for processChallenge, why add test for modifyHeadersWithRefreshTokenCredential (and make it non private)?
If there's some extra that's getting tested that can be tested on processChallenge itself.
fadidurah
approved these changes
Mar 19, 2025
|
✅ Work item link check complete. Description contains link AB#3179147 to an Azure Boards work item. |
somalaya
added
the
No-Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR #2602, we made a change (hotfix) to override the redirect url when it is a cross cloud scenario to attach a PRT header.
The current PR just has some tests to cover the changes made in previous PR
Fixes AB#3179147