Update Json Schema, put JavaScript API behind a flight, Fixes AB#3203956, Closed AB#3203956#2653
Merged
Update Json Schema, put JavaScript API behind a flight, Fixes AB#3203956, Closed AB#3203956#2653
Conversation
|
✅ Work item link check complete. Description contains link AB#3203956 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3203956 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new flight flag to gate the JavaScript API for AuthUx and updates the WebView client to respect that flag.
- Adds
ENABLE_JS_API_FOR_AUTHUXtoCommonFlight - Gates
AuthUxJavaScriptInterfaceexposure behind the new flight inAzureActiveDirectoryWebViewClient - Removes now-unused import in
WebViewAuthorizationFragment
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| common4j/.../CommonFlight.java | Added new flight constant (with a trailing comma typo) |
| common/.../ui/webview/AzureActiveDirectoryWebViewClient.java | Wrapped JS API injection in a flight-enabled check |
| common/.../oauth2/WebViewAuthorizationFragment.java | Removed unused AuthUxJavaScriptInterface import |
Comments suppressed due to low confidence (2)
common/src/main/java/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java:51
- Good catch removing the unused import. Confirm there are no remaining references to
AuthUxJavaScriptInterfacein this class.
import com.microsoft.identity.common.internal.broker.AuthUxJavaScriptInterface;
common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java:122
- There's an extra comma before the semicolon on the last enum constant. Remove the trailing comma so it reads
..., true);.
ENABLE_JS_API_FOR_AUTHUX("EnableJsApiForAuthUx", true),;
rpdome
approved these changes
May 29, 2025
melissaahn
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change was made to the json schema, updated our code to match. Also put JavaScript API behind a flight.
New schema:
{
"correlationID": "$UUID"
"action_name":"write_data",
"action_component":"broker",
"params":
{
"operation": "number_matching",
"sessionID": "$sessionID",
"code_match": "$number"
}
}
Original numberMatch PR: #2617
AB#3203956