Skip to content

Open Id Issuer validation Reporting, Fixes AB#3268088#2751

Merged
mohitc1 merged 15 commits into
devfrom
mchand/openid-issuer-validation
Sep 24, 2025
Merged

Open Id Issuer validation Reporting, Fixes AB#3268088#2751
mohitc1 merged 15 commits into
devfrom
mchand/openid-issuer-validation

Conversation

@mohitc1
Copy link
Copy Markdown
Contributor

@mohitc1 mohitc1 commented Aug 29, 2025

Fixes AB#3268088

This PR implements OpenID issuer validation in the OpenIdProviderConfigurationClient to detect and report cases where the issuer returned in the metadata document doesn't match the expected authority. The validation is gated behind a feature flag and includes telemetry reporting for different validation failure scenarios.

Key changes:

  • Added issuer validation logic with telemetry reporting for OpenID configuration mismatches
  • Introduced new OpenTelemetry attributes and metrics for tracking validation failures
  • Added utility methods for Azure Active Directory cloud validation

@github-actions
Copy link
Copy Markdown

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@github-actions
Copy link
Copy Markdown

❌ Work item link check failed. Description contains AB#3268088 but the Bot could not link it to an Azure Boards work item.

Click here to learn more.

@github-actions
Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3268088 to an Azure Boards work item.

@github-actions github-actions Bot changed the title Open Id Issuer validation Open Id Issuer validation, Fixes AB#3268088 Aug 29, 2025
@mohitc1 mohitc1 marked this pull request as ready for review August 29, 2025 22:28
Copilot AI review requested due to automatic review settings August 29, 2025 22:28
@mohitc1 mohitc1 requested review from a team as code owners August 29, 2025 22:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements OpenID issuer validation in the OpenIdProviderConfigurationClient to detect and report cases where the issuer returned in the metadata document doesn't match the expected authority. The validation is gated behind a feature flag and includes telemetry reporting for different validation failure scenarios.

Key changes:

  • Added issuer validation logic with telemetry reporting for OpenID configuration mismatches
  • Introduced new OpenTelemetry attributes and metrics for tracking validation failures
  • Added utility methods for Azure Active Directory cloud validation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
OpenIdProviderConfigurationClient.java Main implementation of issuer validation with telemetry reporting
AzureActiveDirectoryCloud.java Made isValidated() method public for validation checks
AzureActiveDirectory.java Added utility methods for cloud discovery and public cloud validation
AttributeName.java Added new OpenTelemetry attribute names for issuer validation
CommonFlight.java Added feature flag to control issuer validation reporting
changelog.txt Updated changelog with PR description

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mohitc1 mohitc1 changed the title Open Id Issuer validation, Fixes AB#3268088 Open Id Issuer validation Reporting, Fixes AB#3268088 Sep 4, 2025
@mohitc1 mohitc1 merged commit a7bac98 into dev Sep 24, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants