Add a couple more attributes to track key store errors, Fixes AB#3327441#2753
Merged
Conversation
fadidurah
added
the
No-Changelog
|
✅ Work item link check complete. Description contains link AB#3327441 to an Azure Boards work item. |
1 similar comment
|
✅ Work item link check complete. Description contains link AB#3327441 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3327441 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
1 similar comment
|
❌ Work item link check failed. Description contains AB#3327441 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds additional telemetry attributes to track Android KeyStore operation errors more effectively. It introduces new attributes to capture exception messages and internal error codes from KeyStore exceptions, enhancing observability for debugging KeyStore-related issues.
- Added two new OpenTelemetry attributes:
keystore_exception_messageandkeystore_internal_error_code - Enhanced KeyStore error handling to extract and log KeyStore exception details
- Added helper methods to find KeyStore exceptions in the exception chain and extract internal error codes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| AttributeName.java | Defines two new telemetry attributes for tracking KeyStore exception messages and internal error codes |
| AndroidKeyStoreUtil.java | Implements extraction of KeyStore exception details and adds them to telemetry attributes during unwrap operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
Bot
changed the title
…il/AndroidKeyStoreUtil.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…il/AndroidKeyStoreUtil.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fadidurah
commented
Sep 2, 2025
mohitc1
reviewed
Sep 2, 2025
mohitc1
reviewed
Sep 2, 2025
mohitc1
reviewed
Sep 4, 2025
mohitc1
reviewed
Sep 4, 2025
mohitc1
reviewed
Sep 4, 2025
mohitc1
reviewed
Sep 4, 2025
mohitc1
reviewed
Sep 10, 2025
p3dr0rv
approved these changes
Sep 10, 2025
p3dr0rv
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a couple more attributes to track key store errors
AB#3327441