Add query parameter for Android Release OS Version, Fixes AB#3351713#2754
Merged
Conversation
…il/AndroidKeyStoreUtil.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…il/AndroidKeyStoreUtil.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
✅ Work item link check complete. Description contains link AB#3351713 to an Azure Boards work item. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new query parameter x-client-ReleaseOS to Microsoft authorization requests to support WebCP work by providing Android release OS version information (e.g., "14", "15", "16") instead of API level versions, which is required by Intune Portal.
- Introduces
getAndroidReleaseOs()method across device metadata interfaces and implementations - Adds the new query parameter to authorization requests when the workprofile extra query parameters flight is enabled
- Includes enhanced telemetry for Android KeyStore exceptions with internal error code extraction
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| IDeviceMetadata.java | Adds interface method for retrieving Android release OS version |
| Device.java | Implements static method to access Android release OS through device metadata |
| AndroidDeviceMetadata.java | Provides concrete implementation returning Build.VERSION.RELEASE |
| MockDeviceMetadata.java | Adds test implementation with mock release OS value |
| MicrosoftAuthorizationRequest.java | Integrates new release OS parameter into authorization requests |
| AttributeName.java | Adds telemetry attributes for KeyStore exception details |
| AndroidKeyStoreUtil.java | Enhances exception handling with KeyStore-specific error extraction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rpdome
approved these changes
Sep 10, 2025
siddhijain
approved these changes
Sep 12, 2025
Veena11
approved these changes
Sep 15, 2025
rpdome
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for WebCP work. Intune Portal uses android release os versions, not api level versions. Need this additional query parameter to facilitate flow.
AB#3351713