Skip to content

Add query parameter for Android Release OS Version, Fixes AB#3351713#2754

Merged
fadidurah merged 17 commits into
devfrom
fadi/ex-qp
Sep 15, 2025
Merged

Add query parameter for Android Release OS Version, Fixes AB#3351713#2754
fadidurah merged 17 commits into
devfrom
fadi/ex-qp

Conversation

@fadidurah
Copy link
Copy Markdown
Contributor

@fadidurah fadidurah commented Sep 3, 2025

This is needed for WebCP work. Intune Portal uses android release os versions, not api level versions. Need this additional query parameter to facilitate flow.

AB#3351713

Copilot AI review requested due to automatic review settings September 3, 2025 05:00
@fadidurah fadidurah requested a review from a team as a code owner September 3, 2025 05:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 3, 2025

✅ Work item link check complete. Description contains link AB#3351713 to an Azure Boards work item.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new query parameter x-client-ReleaseOS to Microsoft authorization requests to support WebCP work by providing Android release OS version information (e.g., "14", "15", "16") instead of API level versions, which is required by Intune Portal.

  • Introduces getAndroidReleaseOs() method across device metadata interfaces and implementations
  • Adds the new query parameter to authorization requests when the workprofile extra query parameters flight is enabled
  • Includes enhanced telemetry for Android KeyStore exceptions with internal error code extraction

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
IDeviceMetadata.java Adds interface method for retrieving Android release OS version
Device.java Implements static method to access Android release OS through device metadata
AndroidDeviceMetadata.java Provides concrete implementation returning Build.VERSION.RELEASE
MockDeviceMetadata.java Adds test implementation with mock release OS value
MicrosoftAuthorizationRequest.java Integrates new release OS parameter into authorization requests
AttributeName.java Adds telemetry attributes for KeyStore exception details
AndroidKeyStoreUtil.java Enhances exception handling with KeyStore-specific error extraction

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions Bot changed the title Add query parameter for Android Release OS Version Add query parameter for Android Release OS Version, Fixes AB#3351713 Sep 3, 2025
@fadidurah fadidurah requested a review from a team as a code owner September 3, 2025 05:01
@fadidurah fadidurah added the Skip-Consumers-Check Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR label Sep 10, 2025
@fadidurah fadidurah merged commit 6ed9f94 into dev Sep 15, 2025
19 of 20 checks passed
@fadidurah fadidurah deleted the fadi/ex-qp branch October 17, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Consumers-Check Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants