Move device registration protocol infrastructure to common, Fixes AB#3512895

[mohitc1]

Move device registration protocol types, domain types, controller, packer, and IPC strategies provider from broker to common to enable OneAuth device registration support.

Changes

common4j

• Protocol types: V0 params, responses, interfaces, serializer, constants
• Domain types: IDeviceRegistrationRecord, DeviceRegistrationRecord, DeviceRegistrationRecordWithAccount, exceptions (same simple names as broker4j — broker4j's become thin subclasses)
• Moshi dependency added to build.gradle
• testFixtures: TestHappyPathV0Parameters, TestHappyPathV0Response, DeviceRegistrationTestProtocolConstants

common (Android)

• AndroidDeviceRegistrationClientController — moved from broker, takes DeviceRegistrationIpcStrategiesProvider + IBrokerDiscoveryClient
• AndroidDeviceRegistrationProtocolPacker — moved from broker
• DeviceRegistrationIpcStrategiesProvider — open class providing ContentProvider + BoundService strategies. Broker subclasses to add legacy WPJ strategy.

Tests moved/added

• DeviceRegistrationProtocolSerializerParameterizedTest → common4j (JUnit parameterized, no Robolectric)
• AndroidDeviceRegistrationProtocolPackerTest → common
• DrsErrorResponseExceptionTest → common4j
• AndroidDeviceRegistrationClientControllerTest — new in common (mock-based, 8 tests)

Companion PR

Broker: https://github.com/identity-authnz-teams/ad-accounts-for-android/pull/138

Fixes AB#3512895

[github-actions]

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

[github-actions]

✅ Work item link check complete. Description contains link AB#3512895 to an Azure Boards work item.

[Copilot]

Pull request overview

Moves device registration protocol infrastructure from Broker into Common/Common4j so OneAuth (and other non-broker consumers) can execute device registration operations via shared protocol/domain types, packing/serialization, and Android IPC strategy/controller plumbing.

Changes:

• Adds common4j device registration protocol/domain models, Moshi-based protocol serializer, and supporting exceptions/constants.
• Adds Android-side controller, protocol packer, and IPC strategies provider in common, plus unit tests validating packing and controller strategy fallback behavior.
• Updates build + changelog to include Moshi dependencies and document the new capability.

Reviewed changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
common4j/src/testFixtures/java/com/microsoft/identity/deviceregistration/testprotocols/TestHappyPathV0Response.java	Adds a test protocol response fixture used for serializer/controller tests.
common4j/src/testFixtures/java/com/microsoft/identity/deviceregistration/testprotocols/TestHappyPathV0Parameters.java	Adds a test protocol parameters fixture used for serializer/controller tests.
common4j/src/testFixtures/java/com/microsoft/identity/deviceregistration/testprotocols/DeviceRegistrationTestProtocolConstants.java	Centralizes constants for device registration test protocols.
common4j/src/test/com/microsoft/identity/deviceregistration/java/packer/DeviceRegistrationProtocolSerializerParameterizedTest.java	Adds common4j parameterized unit test for protocol serialization/deserialization.
common4j/src/test/com/microsoft/identity/deviceregistration/java/exception/DrsErrorResponseExceptionTest.kt	Adds unit tests covering DRS error parsing for both JSON formats and invalid inputs.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/UnregisterDeviceV0Response.java	Adds V0 unregister-device response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/ProvisionResourceAccountV0Response.java	Adds V0 provision-resource-account response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/PreProvisionedBlobV0Response.java	Adds V0 pre-provisioned blob response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/InstallCertificateSilentlyV0Response.java	Adds V0 silent cert install response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/IDeviceRegistrationProtocolResponse.java	Defines response marker interface for device registration protocols.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/GetRegistrationStateV0Response.java	Adds V0 get-registration-state response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/GetInstallWpjCertificateIntentRequestV0Response.java	Adds V0 response type for launching WPJ cert install intent.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/GetDeviceTokenV0Response.java	Adds V0 device token response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/GetDeviceRegistrationRecordV0Response.java	Adds V0 single-device-registration-record response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/GetDeviceRegistrationRecordsV0Response.java	Adds V0 list-device-registration-records response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/DeviceRegistrationWithTokensV0Response.java	Adds V0 device-registration-with-tokens response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/DeviceRegistrationPreAuthorizedV0Response.java	Adds V0 pre-authorized device registration response protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/response/AbstractDeviceRegistrationProtocolResponse.java	Adds response base class providing correlation id plumbing.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/UnregisterDeviceV0Parameters.java	Adds V0 unregister-device parameters protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/ProvisionResourceAccountV0Parameters.java	Adds V0 provision-resource-account parameters protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/PreProvisionedBlobV0Parameters.java	Adds V0 pre-provisioned blob parameters protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/InstallCertificateSilentlyV0Parameters.java	Adds V0 silent cert install parameters protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/IDeviceRegistrationProtocolParameters.java	Defines parameters marker interface for device registration protocols.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/GetRegistrationStateV0Parameters.java	Adds V0 get-registration-state parameters protocol type.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/GetInstallWpjCertificateIntentRequestV0Parameters.java	Adds V0 parameters type for WPJ cert install intent request.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/GetDeviceTokenV0Parameters.java	Adds V0 parameters type for device token acquisition.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/GetDeviceRegistrationRecordV0Parameters.java	Adds V0 parameters type for fetching a single record.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/GetDeviceRegistrationRecordsV0Parameters.java	Adds V0 parameters type for fetching all records.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/DeviceRegistrationWithTokensV0Parameters.java	Adds V0 parameters type for device registration using tokens.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/DeviceRegistrationPreAuthorizedV0Parameters.java	Adds V0 parameters type for pre-authorized device registration.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/parameters/AbstractDeviceRegistrationProtocolParameters.java	Adds parameters base class with auto-generated correlation id.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/packer/IDeviceRegistrationProtocolSerializer.java	Adds serializer interface for protocol types.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/packer/IDeviceRegistrationProtocolPacker.java	Adds packer interface for transporting protocol payloads and exceptions.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/packer/DeviceRegistrationProtocolMoshiSerializer.java	Adds Moshi serializer with polymorphic handling for device registration records.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/IDeviceRegistrationProtocol.java	Adds base interface for protocol name/serialization/correlation id.
common4j/src/main/com/microsoft/identity/deviceregistration/java/protocol/DeviceRegistrationProtocolConstants.java	Adds protocol name constants for V0 operations.
common4j/src/main/com/microsoft/identity/deviceregistration/java/exception/DrsErrorResponseException.kt	Adds DRS error parsing exception handling both legacy and OData formats.
common4j/src/main/com/microsoft/identity/deviceregistration/java/exception/DeviceRegistrationException.java	Adds base device registration exception + error codes/messages + factories.
common4j/src/main/com/microsoft/identity/deviceregistration/java/exception/BrokerUpdateRequiredException.java	Adds exception indicating broker upgrade is required.
common4j/src/main/com/microsoft/identity/deviceregistration/java/exception/ApiUpdateRequiredException.java	Adds exception indicating calling app upgrade is required.
common4j/src/main/com/microsoft/identity/deviceregistration/java/api/IDeviceRegistrationRecord.java	Adds shared domain interface for device registration record.
common4j/src/main/com/microsoft/identity/deviceregistration/java/api/IDeviceRegistrationClientController.java	Adds controller interface for executing device registration protocols against broker strategies.
common4j/src/main/com/microsoft/identity/deviceregistration/java/api/DeviceRegistrationRecordWithAccount.java	Adds record subtype carrying account name for legacy execution paths.
common4j/src/main/com/microsoft/identity/deviceregistration/java/api/DeviceRegistrationRecord.java	Adds record implementation used on the wire by common4j serializer.
common4j/build.gradle	Adds Moshi dependencies required by the new serializer.
common/src/test/java/com/microsoft/identity/deviceregistration/AndroidDeviceRegistrationProtocolPackerTest.java	Adds Robolectric tests for Android bundle packing/unpacking and exception propagation.
common/src/test/java/com/microsoft/identity/deviceregistration/AndroidDeviceRegistrationClientControllerTest.kt	Adds controller tests validating strategy ordering/fallback and main-thread enforcement behavior.
common/src/main/java/com/microsoft/identity/deviceregistration/DeviceRegistrationIpcStrategiesProvider.kt	Adds provider for default ContentProvider + BoundService IPC strategies (extensible by broker).
common/src/main/java/com/microsoft/identity/deviceregistration/AndroidDeviceRegistrationProtocolPacker.java	Adds Android Bundle packer for protocol payloads and packed exceptions.
common/src/main/java/com/microsoft/identity/deviceregistration/AndroidDeviceRegistrationClientController.java	Adds Android controller executing protocols via broker IPC strategies with OTel instrumentation.
changelog.txt	Adds vNext entry documenting the migration to Common.