Skip to content

Rename SovSG → GovSG in Common module, Fixes AB#3565148#3068

Merged
mohitc1 merged 3 commits intodevfrom
copilot/fix-renaming-sovsg-to-govsg
Apr 3, 2026
Merged

Rename SovSG → GovSG in Common module, Fixes AB#3565148#3068
mohitc1 merged 3 commits intodevfrom
copilot/fix-renaming-sovsg-to-govsg

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

The Singapore sovereign cloud was incorrectly named "SovSG" — the correct branding is "GovSG". This is a pure identifier rename; the hostname login.sovcloud-identity.sg is unchanged.

Production code

  • AzureActiveDirectoryCloud.java: SOVSG_CLOUD_HOSTGOVSG_CLOUD_HOST, SOVSGGOVSG, JavaDoc updated
  • AzureActiveDirectory.java: import, KNOWN_CLOUD_DISCOVERY_HOSTS entry, and preSeedSovereignClouds() reference updated

Tests

  • AzureActiveDirectoryCloudTest.kt — test functions, local variable sovsggovsg, all constant references
  • AzureActiveDirectoryTest.kttestIsKnownCloudDiscoveryHost_sovsg_govsg
  • AzureActiveDirectoryAuthorityCloudTest.kt — three test functions and local variables renamed
  • AuthorityKnownAuthorityTest.kt — comment and test function renamed

Changelog

  • Added a [PATCH] entry to changelog.txt under vNext noting the rename.
Original prompt

Rename SovSG to GovSG in Common module

Fixes AB#3565148

Objective

Rename all occurrences of SovSG to GovSG in the Common module. The Singapore sovereign cloud was incorrectly named "SovSG" — the correct term is "GovSG".

Context

The sovereign cloud constants and instances in AzureActiveDirectoryCloud.java use the incorrect abbreviation "SovSG" for the Singapore sovereign cloud. This needs to be corrected to "GovSG" across all production code and associated tests. The actual hostname login.sovcloud-identity.sg is correct and must NOT be changed.

Technical Requirements

1. AzureActiveDirectoryCloud.java

Path: common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloud.java

  • Rename constant SOVSG_CLOUD_HOST to GOVSG_CLOUD_HOST (line 127). The string value "login.sovcloud-identity.sg" must NOT change.
  • Update JavaDoc comment: SovSG sovereign cloud to GovSG sovereign cloud (line 144)
  • Rename static instance SOVSG to GOVSG (line 145)
  • Update all references to SOVSG_CLOUD_HOST within the instance constructor call (lines 146-148) to GOVSG_CLOUD_HOST

2. AzureActiveDirectory.java

Path: common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectory.java

  • Rename import: import static ...AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST to GOVSG_CLOUD_HOST (line 31)
  • Rename usage in KNOWN_CLOUD_DISCOVERY_HOSTS set: SOVSG_CLOUD_HOST to GOVSG_CLOUD_HOST (line 119)
  • Rename usage in preSeedSovereignClouds(): AzureActiveDirectoryCloud.SOVSG to AzureActiveDirectoryCloud.GOVSG (line 137)

3. AzureActiveDirectoryCloudTest.kt

Path: common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloudTest.kt

  • Rename test function testSovsgCloudHostConstant() to testGovsgCloudHostConstant()
  • Update reference AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST to AzureActiveDirectoryCloud.GOVSG_CLOUD_HOST
  • Rename test function testSovsgCloudInstance() to testGovsgCloudInstance()
  • Rename local variable val sovsg to val govsg and all its usages
  • Update all AzureActiveDirectoryCloud.SOVSG to AzureActiveDirectoryCloud.GOVSG
  • Update all AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST to AzureActiveDirectoryCloud.GOVSG_CLOUD_HOST

4. AzureActiveDirectoryTest.kt

Path: common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryTest.kt

  • Rename test function testIsKnownCloudDiscoveryHost_sovsg() to testIsKnownCloudDiscoveryHost_govsg()

5. AzureActiveDirectoryAuthorityCloudTest.kt

Path: common4j/src/test/com/microsoft/identity/common/java/authorities/AzureActiveDirectoryAuthorityCloudTest.kt

  • Rename test functions: testIsSameCloudAsAuthority_bothSovsg_returnsTrue to bothGovsg, bleuVsSovsg to bleuVsGovsg, delosVsSovsg to delosVsGovsg
  • Rename local variables val sovsg to val govsg and all usages
  • Update all SOVSG_CLOUD_HOST to GOVSG_CLOUD_HOST

6. AuthorityKnownAuthorityTest.kt

Path: common4j/src/test/com/microsoft/identity/common/java/authorities/AuthorityKnownAuthorityTest.kt

  • Update comment: (SovSG) to (GovSG)
  • Rename test function testIsKnownAuthority_sovsgSovereignCloud() to testIsKnownAuthority_govsgSovereignCloud()
  • Update reference AzureActiveDirectoryCloud.SOVSG_CLOUD_HOST to AzureActiveDirectoryCloud.GOVSG_CLOUD_HOST

Acceptance Criteria

  • All SOVSG, SovSG, sovsg, Sovsg identifiers and comments in common4j are renamed to GOVSG, GovSG, govsg, Govsg respectively.
  • The actual hostname string login.sovcloud-identity.sg is NOT changed anywhere.
  • All existing tests pass after the rename (run ./gradlew :common4j:test).
  • No logic changes — this is purely a naming fix.
  • Follow .github/copilot-instructions.md strictly.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

✅ Work item link check complete. Description contains link AB#3565148 to an Azure Boards work item.

@github-actions github-actions Bot changed the title [WIP] Fix rename SovSG to GovSG in Common module [WIP] Fix rename SovSG to GovSG in Common module, Fixes AB#3565148 Apr 3, 2026
Copilot AI changed the title [WIP] Fix rename SovSG to GovSG in Common module, Fixes AB#3565148 Rename SovSG → GovSG in Common module Apr 3, 2026
Copilot AI requested a review from mohitc1 April 3, 2026 00:27
@github-actions github-actions Bot changed the title Rename SovSG → GovSG in Common module Rename SovSG → GovSG in Common module, Fixes AB#3565148 Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

❌ Invalid work item number: AB#3565148

. Work item number must be a valid integer.

Click here to learn more.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

❌ Invalid work item number: AB#3565148

. Work item number must be a valid integer.

Click here to learn more.

@mohitc1
Copy link
Copy Markdown
Contributor

mohitc1 commented Apr 3, 2026

@copilot add changelog as well.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 3, 2026

@copilot add changelog as well.

Added a changelog entry in commit 0ff87f4:

- [PATCH] Rename SovSG to GovSG for the Singapore sovereign cloud identifiers (#3068)

@mohitc1 mohitc1 marked this pull request as ready for review April 3, 2026 16:37
@mohitc1 mohitc1 requested review from a team as code owners April 3, 2026 16:37
Copilot AI review requested due to automatic review settings April 3, 2026 16:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the Singapore sovereign cloud identifier from SovSG to GovSG across the Common4j Azure Active Directory cloud constants and corresponding unit tests, while keeping the actual host (login.sovcloud-identity.sg) unchanged.

Changes:

  • Renamed SOVSG_CLOUD_HOSTGOVSG_CLOUD_HOST and SOVSGGOVSG in AzureActiveDirectoryCloud, and updated AzureActiveDirectory to reference the new identifiers.
  • Updated all impacted tests to use the new GovSG naming.
  • Added a vNext changelog entry documenting the rename.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloud.java Renames the Singapore sovereign cloud public constant/instance identifiers.
common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectory.java Updates known-host set and sovereign-cloud pre-seeding to reference GOVSG.
common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloudTest.kt Renames tests and updates assertions to use GOVSG*.
common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryTest.kt Renames the known-cloud-discovery-host test to govsg.
common4j/src/test/com/microsoft/identity/common/java/authorities/AzureActiveDirectoryAuthorityCloudTest.kt Renames test cases/locals and updates host constant usage.
common4j/src/test/com/microsoft/identity/common/java/authorities/AuthorityKnownAuthorityTest.kt Renames the GovSG known-authority test and updates the host reference in the URL.
changelog.txt Adds a vNext [PATCH] entry describing the identifier rename.

Comment thread changelog.txt
@mohitc1 mohitc1 merged commit cd914e4 into dev Apr 3, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants