Rename SovSG → GovSG in Common module, Fixes AB#3565148#3068
Conversation
|
✅ Work item link check complete. Description contains link AB#3565148 to an Azure Boards work item. |
Agent-Logs-Url: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/sessions/5ba0899b-183d-4e79-8a83-9a47cce215ee Co-authored-by: mohitc1 <22034758+mohitc1@users.noreply.github.com>
|
❌ Invalid work item number: AB#3565148
Click here to learn more. |
1 similar comment
|
❌ Invalid work item number: AB#3565148
Click here to learn more. |
|
@copilot add changelog as well. |
Agent-Logs-Url: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/sessions/aaa9abb0-c63c-49dd-bb24-17d6d596c0e0 Co-authored-by: mohitc1 <22034758+mohitc1@users.noreply.github.com>
Added a changelog entry in commit |
There was a problem hiding this comment.
Pull request overview
Renames the Singapore sovereign cloud identifier from SovSG to GovSG across the Common4j Azure Active Directory cloud constants and corresponding unit tests, while keeping the actual host (login.sovcloud-identity.sg) unchanged.
Changes:
- Renamed
SOVSG_CLOUD_HOST→GOVSG_CLOUD_HOSTandSOVSG→GOVSGinAzureActiveDirectoryCloud, and updatedAzureActiveDirectoryto reference the new identifiers. - Updated all impacted tests to use the new
GovSGnaming. - Added a vNext changelog entry documenting the rename.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloud.java | Renames the Singapore sovereign cloud public constant/instance identifiers. |
| common4j/src/main/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectory.java | Updates known-host set and sovereign-cloud pre-seeding to reference GOVSG. |
| common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryCloudTest.kt | Renames tests and updates assertions to use GOVSG*. |
| common4j/src/test/com/microsoft/identity/common/java/providers/microsoft/azureactivedirectory/AzureActiveDirectoryTest.kt | Renames the known-cloud-discovery-host test to govsg. |
| common4j/src/test/com/microsoft/identity/common/java/authorities/AzureActiveDirectoryAuthorityCloudTest.kt | Renames test cases/locals and updates host constant usage. |
| common4j/src/test/com/microsoft/identity/common/java/authorities/AuthorityKnownAuthorityTest.kt | Renames the GovSG known-authority test and updates the host reference in the URL. |
| changelog.txt | Adds a vNext [PATCH] entry describing the identifier rename. |
The Singapore sovereign cloud was incorrectly named "SovSG" — the correct branding is "GovSG". This is a pure identifier rename; the hostname
login.sovcloud-identity.sgis unchanged.Production code
AzureActiveDirectoryCloud.java:SOVSG_CLOUD_HOST→GOVSG_CLOUD_HOST,SOVSG→GOVSG, JavaDoc updatedAzureActiveDirectory.java: import,KNOWN_CLOUD_DISCOVERY_HOSTSentry, andpreSeedSovereignClouds()reference updatedTests
AzureActiveDirectoryCloudTest.kt— test functions, local variablesovsg→govsg, all constant referencesAzureActiveDirectoryTest.kt—testIsKnownCloudDiscoveryHost_sovsg→_govsgAzureActiveDirectoryAuthorityCloudTest.kt— three test functions and local variables renamedAuthorityKnownAuthorityTest.kt— comment and test function renamedChangelog
[PATCH]entry tochangelog.txtundervNextnoting the rename.Original prompt