Making AI recommended changes for Adding Authenticator to Android complete#3069
Making AI recommended changes for Adding Authenticator to Android complete#3069rohitluthra wants to merge 1 commit intodevfrom
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Pull request overview
Adds new BrokerData entries intended to represent Microsoft Intune (package com.microsoft.intune) broker identities, exposing them as Java-callable static properties from BrokerData’s companion object.
Changes:
- Added
@JvmStaticBrokerDatainstancesprodIntuneCEanddebugIntuneCE. - Wired them to Intune package/signature constants in
AuthenticationConstants.Broker.
| val prodIntuneCE = BrokerData( | ||
| AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME, | ||
| AuthenticationConstants.Broker.INTUNE_APP_SHA512_RELEASE_SIGNATURE, | ||
| "prodIntuneCE" | ||
| ) | ||
|
|
||
| @JvmStatic | ||
| val debugIntuneCE = BrokerData( | ||
| AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME, | ||
| AuthenticationConstants.Broker.INTUNE_APP_SHA512_DEBUG_SIGNATURE, | ||
| "debugIntuneCE" | ||
| ) | ||
|
|
||
| @JvmStatic |
There was a problem hiding this comment.
prodIntuneCE / debugIntuneCE are added but not wired into any of the broker allowlists (prodBrokers, debugBrokers, accountManagerBrokers). Impact: getKnownBrokerApps() / isAccountManagerSupported() will never return/recognize these entries, so the change won’t actually enable Intune as a broker and may mislead future maintainers. Recommendation: either add these new BrokerData instances to the appropriate sets (and update the corresponding unit tests/expected counts), or remove them if they are not meant to participate in broker discovery/validation yet.
| val prodIntuneCE = BrokerData( | |
| AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME, | |
| AuthenticationConstants.Broker.INTUNE_APP_SHA512_RELEASE_SIGNATURE, | |
| "prodIntuneCE" | |
| ) | |
| @JvmStatic | |
| val debugIntuneCE = BrokerData( | |
| AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME, | |
| AuthenticationConstants.Broker.INTUNE_APP_SHA512_DEBUG_SIGNATURE, | |
| "debugIntuneCE" | |
| ) | |
| @JvmStatic |
| val prodIntuneCE = BrokerData( | ||
| AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME, | ||
| AuthenticationConstants.Broker.INTUNE_APP_SHA512_RELEASE_SIGNATURE, | ||
| "prodIntuneCE" | ||
| ) |
There was a problem hiding this comment.
PR metadata says this is to “support Authenticator”, but this hunk introduces Intune (INTUNE_APP_PACKAGE_NAME) broker entries instead. Impact: reviewers and downstream consumers may miss the actual intent/required follow-up changes. Recommendation: update the PR title/description to reflect the Intune broker addition (or adjust the change to target Authenticator if that was the real goal).
shahzaibj
left a comment
There was a problem hiding this comment.
I believe these were already moved to AppRegistry - so why adding them here?
Added these changes to correctly support Authenticator app in Android complete.
Its strcutrely only adds JVM Static function