Skip to content

Making AI recommended changes for Adding Authenticator to Android complete#3069

Closed
rohitluthra wants to merge 1 commit intodevfrom
rohitluthra/addAuthenticatorToAndroidComplete
Closed

Making AI recommended changes for Adding Authenticator to Android complete#3069
rohitluthra wants to merge 1 commit intodevfrom
rohitluthra/addAuthenticatorToAndroidComplete

Conversation

@rohitluthra
Copy link
Copy Markdown
Contributor

Added these changes to correctly support Authenticator app in Android complete.

Its strcutrely only adds JVM Static function

@rohitluthra rohitluthra requested a review from a team as a code owner April 6, 2026 18:36
Copilot AI review requested due to automatic review settings April 6, 2026 18:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new BrokerData entries intended to represent Microsoft Intune (package com.microsoft.intune) broker identities, exposing them as Java-callable static properties from BrokerData’s companion object.

Changes:

  • Added @JvmStatic BrokerData instances prodIntuneCE and debugIntuneCE.
  • Wired them to Intune package/signature constants in AuthenticationConstants.Broker.

Comment on lines +160 to 173
val prodIntuneCE = BrokerData(
AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME,
AuthenticationConstants.Broker.INTUNE_APP_SHA512_RELEASE_SIGNATURE,
"prodIntuneCE"
)

@JvmStatic
val debugIntuneCE = BrokerData(
AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME,
AuthenticationConstants.Broker.INTUNE_APP_SHA512_DEBUG_SIGNATURE,
"debugIntuneCE"
)

@JvmStatic
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prodIntuneCE / debugIntuneCE are added but not wired into any of the broker allowlists (prodBrokers, debugBrokers, accountManagerBrokers). Impact: getKnownBrokerApps() / isAccountManagerSupported() will never return/recognize these entries, so the change won’t actually enable Intune as a broker and may mislead future maintainers. Recommendation: either add these new BrokerData instances to the appropriate sets (and update the corresponding unit tests/expected counts), or remove them if they are not meant to participate in broker discovery/validation yet.

Suggested change
val prodIntuneCE = BrokerData(
AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME,
AuthenticationConstants.Broker.INTUNE_APP_SHA512_RELEASE_SIGNATURE,
"prodIntuneCE"
)
@JvmStatic
val debugIntuneCE = BrokerData(
AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME,
AuthenticationConstants.Broker.INTUNE_APP_SHA512_DEBUG_SIGNATURE,
"debugIntuneCE"
)
@JvmStatic

Copilot uses AI. Check for mistakes.
Comment on lines +160 to +164
val prodIntuneCE = BrokerData(
AuthenticationConstants.Broker.INTUNE_APP_PACKAGE_NAME,
AuthenticationConstants.Broker.INTUNE_APP_SHA512_RELEASE_SIGNATURE,
"prodIntuneCE"
)
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR metadata says this is to “support Authenticator”, but this hunk introduces Intune (INTUNE_APP_PACKAGE_NAME) broker entries instead. Impact: reviewers and downstream consumers may miss the actual intent/required follow-up changes. Recommendation: update the PR title/description to reflect the Intune broker addition (or adjust the change to target Authenticator if that was the real goal).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@shahzaibj shahzaibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these were already moved to AppRegistry - so why adding them here?

@rohitluthra rohitluthra closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants