Skip to content

Remove legacy WPJ Account Authenticator IPC strategy from Common, Fixes AB#3571860 #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Remove legacy WPJ Account Authenticator IPC strategy from Common, Fixes AB#3571860 #3077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a155070
Initial plan
Copilot Apr 8, 2026
b0a2040
Remove legacy WPJ Account Authenticator IPC strategy references
Copilot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions common/src/main/java/com/microsoft/identity/common/internal/broker/ipc/IIpcStrategy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ interface IIpcStrategy {
enum class Type(val value: String) {
BOUND_SERVICE("bound_service"),
ACCOUNT_MANAGER_ADD_ACCOUNT("account_manager_add_account"),
CONTENT_PROVIDER("content_provider"),
LEGACY_ACCOUNT_AUTHENTICATOR_FOR_WPJ_API("legacy_account_authenticator_for_wpj_api");
CONTENT_PROVIDER("content_provider");

override fun toString(): String {
return value
Expand Down
3 changes: 0 additions & 3 deletions .../com/microsoft/identity/deviceregistration/AndroidDeviceRegistrationClientController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import static com.microsoft.identity.common.internal.broker.ipc.BrokerOperationBundle.Operation.DEVICE_REGISTRATION_OPERATIONS;
import static com.microsoft.identity.common.internal.broker.ipc.IIpcStrategy.Type.BOUND_SERVICE;
import static com.microsoft.identity.common.internal.broker.ipc.IIpcStrategy.Type.CONTENT_PROVIDER;
import static com.microsoft.identity.common.internal.broker.ipc.IIpcStrategy.Type.LEGACY_ACCOUNT_AUTHENTICATOR_FOR_WPJ_API;
import static com.microsoft.identity.common.java.exception.ClientException.INVALID_BROKER_BUNDLE;

import android.content.Context;
Expand Down Expand Up @@ -234,8 +233,6 @@ private void setIpcStrategyTelemetryAttributes(
attributeName = AttributeName.content_provider_status.name();
} else if (BOUND_SERVICE.equals(strategyType)) {
attributeName = AttributeName.bound_service_status.name();
} else if (LEGACY_ACCOUNT_AUTHENTICATOR_FOR_WPJ_API.equals(strategyType)) {
attributeName = AttributeName.legacy_account_manager_status.name();
} else {
attributeName = null;
}
Expand Down
4 changes: 1 addition & 3 deletions ...java/com/microsoft/identity/deviceregistration/DeviceRegistrationIpcStrategiesProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import com.microsoft.identity.common.logging.Logger
* Provides IPC strategies for device registration communication.
*
* Default implementation supplies ContentProvider + BoundService strategies.
* Broker subclass overrides [getStrategies] to add WpjLegacyAccountAuthenticatorStrategy.
* Broker subclass overrides [getStrategies] to add additional strategies.
*
* @param supportsBoundService whether to include the BoundService IPC strategy.
*/
Expand All @@ -50,8 +50,6 @@ open class DeviceRegistrationIpcStrategiesProvider @JvmOverloads constructor(
* Returns the list of IPC strategies to use for device registration.
* Default: ContentProvider + BoundService (if supported).
*
* Broker overrides this to append legacy strategy after calling super.
*
* @param context application context.
* @param components platform components for the active broker.
* @param activeBrokerPackageName package name of the active broker.
Expand Down
7 changes: 1 addition & 6 deletions ...test/java/com/microsoft/identity/common/internal/broker/ipc/IpcStrategyWithBackupTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ class IpcStrategyWithBackupTests {
shouldThrowException = true),
MockIpc(type = IIpcStrategy.Type.BOUND_SERVICE,
shouldThrowException = true),
MockIpc(type = IIpcStrategy.Type.LEGACY_ACCOUNT_AUTHENTICATOR_FOR_WPJ_API,
shouldThrowException = true),
)
)

Expand All @@ -93,7 +91,7 @@ class IpcStrategyWithBackupTests {
backup = listOf(
MockIpc(type = IIpcStrategy.Type.ACCOUNT_MANAGER_ADD_ACCOUNT,
shouldThrowException = true),
MockIpc(type = IIpcStrategy.Type.LEGACY_ACCOUNT_AUTHENTICATOR_FOR_WPJ_API,
MockIpc(type = IIpcStrategy.Type.BOUND_SERVICE,
shouldThrowException = true),
)
)
Expand All @@ -111,7 +109,6 @@ class IpcStrategyWithBackupTests {
MockIpc(type = IIpcStrategy.Type.ACCOUNT_MANAGER_ADD_ACCOUNT,
shouldThrowException = true),
MockIpc(type = IIpcStrategy.Type.BOUND_SERVICE),
MockIpc(type = IIpcStrategy.Type.LEGACY_ACCOUNT_AUTHENTICATOR_FOR_WPJ_API),
)
)

Expand Down Expand Up @@ -144,8 +141,6 @@ class IpcStrategyWithBackupTests {
shouldThrowException = true),
MockIpc(type = IIpcStrategy.Type.BOUND_SERVICE,
shouldThrowException = true),
MockIpc(type = IIpcStrategy.Type.LEGACY_ACCOUNT_AUTHENTICATOR_FOR_WPJ_API,
shouldThrowException = true),
)
)

Expand Down
5 changes: 0 additions & 5 deletions common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,11 +645,6 @@ public enum AttributeName {
*/
bound_service_status,

/**
* Indicates the status of Legacy Account Manager IPC strategy for device registration.
*/
legacy_account_manager_status,

/**
* Indicates the name of the device registration protocol being executed.
*/
Expand Down
Loading