Merged
Conversation
…ureActiveDirectoryAuthority, Fixes AB#3578299 (#3083) ## Hotfix for release/24.1.1 Cherry-pick of PR #3082 (dev branch fix) onto \working/release/24.1.1\. ### Problem ABBA deadlock between \AzureActiveDirectory.class\ and \AzureActiveDirectoryAuthority.class\ monitors under high concurrency (multiple apps calling into Broker simultaneously), causing ANR in Microsoft Authenticator. ### Changes - Extract \�uthority.getAuthorityURL()\ outside synchronized scopes - Remove \synchronized\ from read-only \ConcurrentHashMap\ methods - Remove \synchronized\ from \AzureActiveDirectoryAuthority.getAzureActiveDirectoryCloud()\ and \isSameCloudAsAuthority()\ - Fix race in \isValidCloudHost()\ (null-check before \isValidated()\) - Improve error handling in \getKnownAuthorityResult()\ - Add concurrency regression tests ### Testing All \common4j\ tests pass on this branch. [AB#3578299](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3578299) Co-authored-by: Mohit <mchand@microsoft.com>
Merges \ elease/24.1.0\ into \working/release/24.1.1\. ### Changes from release/24.1.0 - PackageHelper updates - Changelog updates ### Preserved from working/release/24.1.1 - Deadlock hotfix (PR #3083) - RC1 versioning Co-authored-by: Cesar Acosta <cacosta333@hotmail.com> Co-authored-by: Azure DevOps Pipeline <build-agent@azuredevops.com> Co-authored-by: Siddhi <siddhijain@microsoft.com> Co-authored-by: Mohit <mchand@microsoft.com>
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
mohitc1
added
the
Skip-Consumers-Check
p3dr0rv
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.