Conversation
mohitc1
added
No-Changelog
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an overload of handleButtonClickForObjectWithTextSafely that accepts an explicit existence timeout to resolve a build break introduced by a prior change.
Changes:
- Introduced a new
handleButtonClickForObjectWithTextSafely(String text, long existsTimeout)overload. - Uses
obtainUiObjectWithText(text, existsTimeout)before attempting a click and logs a warning if not found.
…ent/ui/automation/utils/UiAutomatorUtils.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…thTextSafely overload Agent-Logs-Url: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/sessions/3221e7ff-7be3-439a-a73d-f90bff630187 Co-authored-by: mohitc1 <22034758+mohitc1@users.noreply.github.com>
|
✅ Work item link check complete. Description contains link AB#3586240 to an Azure Boards work item. |
somalaya
approved these changes
Apr 24, 2026
github-actions
Bot
changed the title
siddhijain
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen here
https://identitydivision.visualstudio.com/Engineering/ISP%20-%20ID%20Risk%20for%20Passkey%20Registration%20and%20Recovery/_build/results?buildId=1626465&view=logs&s=ff4555a9-e895-5c04-ab14-88c3aa79b4da&j=9a146641-6417-5767-ad44-2e332adab356
Seems to have happened after AzureAD/microsoft-authentication-library-for-android#2502
/mnt/vss/_work/1/s/msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/foci/TestCase833544.java:107: error: method handleButtonClickForObjectWithTextSafely in class UiAutomatorUtils cannot be applied to given types;
UiAutomatorUtils.handleButtonClickForObjectWithTextSafely("Close", CommonUtils.FIND_UI_ELEMENT_TIMEOUT_SHORT);
Fixes AB#3586240