Skip to content

Commit 71ac706

Browse files
authored
Remove native auth warning logs, Fixes AB#3403843 (#2397)
[AB#3403843](https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3403843) Remove native auth doc warning and log warning from preview features in native auth SDK. This is no longer needed going into preview.
1 parent 76f578a commit 71ac706

2 files changed

Lines changed: 0 additions & 26 deletions

File tree

msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/JITStates.kt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ abstract class BaseJITSubmitChallengeState(
4343
private val config: NativeAuthPublicClientApplicationConfiguration
4444
) : BaseState(continuationToken = continuationToken, correlationId = correlationId), State, Parcelable {
4545
suspend fun internalChallengeAuthMethod(parameters: NativeAuthChallengeAuthMethodParameters, tag: String): RegisterStrongAuthChallengeResult {
46-
Logger.warn(
47-
tag,
48-
"Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications."
49-
)
5046
if (parameters.verificationContact.isBlank()) {
5147
return RegisterStrongAuthChallengeError(
5248
errorType = ErrorTypes.INVALID_INPUT,
@@ -168,7 +164,6 @@ class RegisterStrongAuthState(
168164
/**
169165
* Requests the server to send the challenge to the default authentication method; callback variant
170166
*
171-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
172167
* @param parameters [com.microsoft.identity.nativeauth.parameters.NativeAuthChallengeAuthMethodParameters] Parameters used to challenge an authentication method.
173168
* @param callback [com.microsoft.identity.nativeauth.statemachine.states.RegisterStrongAuthState.ChallengeAuthMethodCallback] to receive the result on.
174169
*/
@@ -192,7 +187,6 @@ class RegisterStrongAuthState(
192187
/**
193188
* Requests the server to send the challenge to the default authentication method; Kotlin coroutines variant.
194189
*
195-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
196190
* @param parameters [com.microsoft.identity.nativeauth.parameters.NativeAuthChallengeAuthMethodParameters] Parameters used to challenge an authentication method.
197191
* @return The result of the challenge authentication method action.
198192
*/
@@ -251,7 +245,6 @@ class RegisterStrongAuthVerificationRequiredState(
251245
/**
252246
* Submits the challenge value to the server; callback variant.
253247
*
254-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
255248
* @param challenge The challenge value to be submitted.
256249
* @param callback [com.microsoft.identity.nativeauth.statemachine.states.RegisterStrongAuthState.SubmitChallengeCallback] to receive the result on.
257250
*/
@@ -275,7 +268,6 @@ class RegisterStrongAuthVerificationRequiredState(
275268
/**
276269
* Submits the challenge value to the server; Kotlin coroutines variant.
277270
*
278-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
279271
* @param challenge The challenge value to be submitted.
280272
* @return The results of the submit challenge action.
281273
*/
@@ -286,10 +278,6 @@ class RegisterStrongAuthVerificationRequiredState(
286278
methodName = "${TAG}.submitChallenge(challenge: String)"
287279
)
288280

289-
Logger.warn(
290-
TAG,
291-
"Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications."
292-
)
293281
if (challenge.isBlank()) {
294282
return RegisterStrongAuthSubmitChallengeError(
295283
errorMessage = "Empty challenge provided.",
@@ -377,7 +365,6 @@ class RegisterStrongAuthVerificationRequiredState(
377365
/**
378366
* Requests the server to send the challenge to the default authentication method; callback variant
379367
*
380-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
381368
* @param parameters [com.microsoft.identity.nativeauth.parameters.NativeAuthChallengeAuthMethodParameters] Parameters used to challenge an authentication method.
382369
* @param callback [com.microsoft.identity.nativeauth.statemachine.states.RegisterStrongAuthState.ChallengeAuthMethodCallback] to receive the result on.
383370
*/
@@ -401,7 +388,6 @@ class RegisterStrongAuthVerificationRequiredState(
401388
/**
402389
* Requests the server to send the challenge to the default authentication method; Kotlin coroutines variant.
403390
*
404-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
405391
* @param parameters [com.microsoft.identity.nativeauth.parameters.NativeAuthChallengeAuthMethodParameters] Parameters used to challenge an authentication method.
406392
* @return The result of the challenge authentication method action.
407393
*/

msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/MFAStates.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ class AwaitingMFAState(
7171
/**
7272
* Requests a challenge to be sent to the user's default authentication method; callback variant.
7373
*
74-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
7574
* @param authMethod [com.microsoft.identity.nativeauth.AuthMethod] the authentication method used for the challenge operation.
7675
* @param callback [com.microsoft.identity.nativeauth.statemachine.states.AwaitingMFAState.RequestChallengeCallback] to receive the result on.
7776
* @return The result of the request challenge action.
@@ -96,7 +95,6 @@ class AwaitingMFAState(
9695
/**
9796
* Requests a challenge to be sent to the authentication method; Kotlin coroutines variant.
9897
*
99-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
10098
* @return The result of the request challenge action.
10199
*/
102100
suspend fun requestChallenge(authMethod: AuthMethod): MFARequiredResult {
@@ -106,8 +104,6 @@ class AwaitingMFAState(
106104
methodName = "${TAG}.requestChallenge(authMethod: AuthMethod)"
107105
)
108106

109-
Logger.warn(TAG, "Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.")
110-
111107
return withContext(Dispatchers.IO) {
112108
try {
113109
val params = CommandParametersAdapter.createMFAChallengeAuthMethodCommandParameters(
@@ -230,7 +226,6 @@ class MFARequiredState(
230226
/**
231227
* Requests a challenge to be sent to the user's default authentication method; callback variant.
232228
*
233-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
234229
* @param authMethod [com.microsoft.identity.nativeauth.AuthMethod] the authentication method used for the challenge operation.
235230
* @param callback [com.microsoft.identity.nativeauth.statemachine.states.AwaitingMFAState.RequestChallengeCallback] to receive the result on.
236231
* @return The result of the request challenge action.
@@ -255,7 +250,6 @@ class MFARequiredState(
255250
/**
256251
* Requests a challenge to be sent to authentication method; Kotlin coroutines variant.
257252
*
258-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
259253
* @param authMethod [com.microsoft.identity.nativeauth.AuthMethod] the authentication method used for the challenge operation.
260254
* @return The result of the request challenge action.
261255
*/
@@ -266,8 +260,6 @@ class MFARequiredState(
266260
methodName = "${TAG}.requestChallenge(authMethod: AuthMethod)"
267261
)
268262

269-
Logger.warn(TAG, "Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.")
270-
271263
return withContext(Dispatchers.IO) {
272264
try {
273265
val params = CommandParametersAdapter.createMFAChallengeAuthMethodCommandParameters(
@@ -354,7 +346,6 @@ class MFARequiredState(
354346
/**
355347
* Submits the challenge value to the server; callback variant.
356348
*
357-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
358349
* @param callback [com.microsoft.identity.nativeauth.statemachine.states.MFARequiredState.SubmitChallengeCallback] to receive the result on.
359350
* @return The result of the submit challenge action.
360351
*/
@@ -378,7 +369,6 @@ class MFARequiredState(
378369
/**
379370
* Submits the challenge value to the server; Kotlin coroutines variant.
380371
*
381-
* <strong><u>Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.</u></strong>
382372
* @return The result of the submit challenge action.
383373
*/
384374
suspend fun submitChallenge(challenge: String): MFASubmitChallengeResult {
@@ -388,8 +378,6 @@ class MFARequiredState(
388378
methodName = "${TAG}.submitChallenge(challenge: String)"
389379
)
390380

391-
Logger.warn(TAG, "Warning: this API is experimental. It may be changed in the future without notice. Do not use in production applications.")
392-
393381
return withContext(Dispatchers.IO) {
394382
try {
395383
val params = CommandParametersAdapter.createMFASubmitChallengeCommandParameters(

0 commit comments

Comments
 (0)