Apply code-review feedback: input validation, interrupt handling, dispatch try/catch, richer error messages

Agent-Logs-Url: https://github.com/AzureAD/microsoft-authentication-library-for-android/sessions/3b42a162-07a3-4bfb-9b33-bf29afe1d139

Co-authored-by: rpdome <19558668+rpdome@users.noreply.github.com>

Author: Copilot

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/concurrent/ConcurrentAcquireTokenSilentHelper.java

@@ -158,6 +158,16 @@ public static StressResult run(
             final long perWaveTimeoutSec,
             final SilentTokenRequester requester) throws InterruptedException {
 
+        if (threadCount <= 0) {
+            throw new IllegalArgumentException("threadCount must be > 0");
+        }
+        if (iterations <= 0) {
+            throw new IllegalArgumentException("iterations must be > 0");
+        }
+        if (perWaveTimeoutSec <= 0) {
+            throw new IllegalArgumentException("perWaveTimeoutSec must be > 0");
+        }
+
         final AtomicBoolean stopped = new AtomicBoolean(false);
         final AtomicReference<CountDownLatch> currentWaveLatch = new AtomicReference<>();
         final List<String> errors = Collections.synchronizedList(new ArrayList<>());
@@ -181,11 +191,14 @@ public static StressResult run(
                         // Synchronise all threads so every wave fires together.
                         try {
                             waveBarrier.await();
+                        } catch (final InterruptedException ie) {
+                            Thread.currentThread().interrupt();
+                            break;
                         } catch (final Exception barrierEx) {
                             if (!stopped.get()) {
                                 errors.add("Thread " + threadIndex
                                         + " barrier failed at wave " + iter
-                                        + ": " + barrierEx.getMessage());
+                                        + ": " + barrierEx);
                             }
                             break;
                         }
@@ -200,7 +213,13 @@ public static StressResult run(
                         final CountDownLatch waveDone = currentWaveLatch.get();
                         final int currentIter = iter;
 
-                        requester.request(threadIndex, currentIter, waveDone, errors);
+                        try {
+                            requester.request(threadIndex, currentIter, waveDone, errors);
+                        } catch (final Throwable dispatchError) {
+                            errors.add("Thread " + threadIndex + " iter " + currentIter
+                                    + " dispatch failed: " + dispatchError);
+                            waveDone.countDown();
+                        }
 
                         // Wait for every callback in this wave before starting the next.
                         try {

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/concurrent/TestCaseConcurrentAcquireTokenSilent.java

@@ -177,8 +177,9 @@ public void onSuccess(
                                                 public void onError(
                                                         final MsalException exception) {
                                                     errors.add("Thread " + threadIndex
-                                                            + " iter " + iteration + ": "
-                                                            + exception.getMessage());
+                                                            + " iter " + iteration + " ["
+                                                            + exception.getErrorCode() + "]: "
+                                                            + exception);
                                                     done.countDown();
                                                 }
                                             })