Remove TOTAL_TIMEOUT_SECONDS from public API; derive backstop internally in helper

Agent-Logs-Url: https://github.com/AzureAD/microsoft-authentication-library-for-android/sessions/950932aa-114e-4f33-ba7f-a6abd4506823

Co-authored-by: rpdome <19558668+rpdome@users.noreply.github.com>

Author: Copilot

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/concurrent/ConcurrentAcquireTokenSilentHelper.java

@@ -139,12 +139,15 @@ public interface SilentTokenRequester {
      * that counts from {@code threadCount} down to zero, so callers must
      * still call {@code done.countDown()} exactly once per request.</p>
      *
+     * <p>A safety backstop of {@code iterations × perWaveTimeoutSec} seconds is
+     * enforced internally on the final {@link CountDownLatch#await} to guard
+     * against unexpected hangs; in practice the per-wave timeout unblocks all
+     * threads before this ceiling is reached.</p>
+     *
      * @param threadCount       number of concurrent threads
      * @param iterations        number of iteration waves per thread
      * @param perWaveTimeoutSec maximum seconds for all {@code threadCount}
      *                          callbacks in one wave to complete
-     * @param totalTimeoutSec   seconds to wait for all threads to finish all
-     *                          iterations (safety backstop)
      * @param requester         supplies one MSAL call per (thread, iteration)
      * @return the {@link StressResult} containing the completion flag and any errors
      * @throws InterruptedException if the calling thread is interrupted while awaiting
@@ -154,7 +157,6 @@ public static StressResult run(
             final int threadCount,
             final int iterations,
             final long perWaveTimeoutSec,
-            final long totalTimeoutSec,
             final SilentTokenRequester requester) throws InterruptedException {
 
         final AtomicBoolean stopped = new AtomicBoolean(false);
@@ -224,7 +226,9 @@ public static StressResult run(
             }, "ConcurrentATS-" + threadIndex).start();
         }
 
-        final boolean allCompleted = allThreadsDone.await(totalTimeoutSec, TimeUnit.SECONDS);
+        final boolean allCompleted =
+                allThreadsDone.await(
+                        (long) iterations * perWaveTimeoutSec, TimeUnit.SECONDS);
         return new StressResult(allCompleted, errors);
     }
 }

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/concurrent/TestCaseConcurrentAcquireTokenSilent.java

@@ -98,15 +98,6 @@ public class TestCaseConcurrentAcquireTokenSilent extends AbstractMsalBrokerTest
      */
     private static final long PER_WAVE_TIMEOUT_SECONDS = 10;
 
-    /**
-     * Overall test timeout (safety backstop): exactly
-     * {@value #ITERATIONS_PER_THREAD} waves × {@value #PER_WAVE_TIMEOUT_SECONDS} s/wave = 1000 s.
-     * The per-wave timeout already aborts the run on the first stuck wave,
-     * so the total can never exceed this bound.
-     */
-    private static final long TOTAL_TIMEOUT_SECONDS =
-            ITERATIONS_PER_THREAD * PER_WAVE_TIMEOUT_SECONDS;
-
     @Test
     public void test_concurrentAcquireTokenSilent_withBroker() throws Throwable {
         final String username = mLabAccount.getUsername();
@@ -167,7 +158,6 @@ public void handleUserInteraction() {
                         CONCURRENT_THREADS,
                         ITERATIONS_PER_THREAD,
                         PER_WAVE_TIMEOUT_SECONDS,
-                        TOTAL_TIMEOUT_SECONDS,
                         (threadIndex, iteration, done, errors) -> {
                             final AcquireTokenSilentParameters silentParameters =
                                     new AcquireTokenSilentParameters.Builder()
@@ -203,9 +193,8 @@ public void onError(
         Assert.assertTrue(
                 "Concurrent AcquireTokenSilent stress test got stuck – not all "
                         + CONCURRENT_THREADS + " threads completed "
-                        + ITERATIONS_PER_THREAD + " iterations within "
-                        + TOTAL_TIMEOUT_SECONDS + "s (per-wave timeout: "
-                        + PER_WAVE_TIMEOUT_SECONDS + "s)",
+                        + ITERATIONS_PER_THREAD + " iterations"
+                        + " (per-wave timeout: " + PER_WAVE_TIMEOUT_SECONDS + "s)",
                 result.allCompleted);
 
         Assert.assertTrue(