UI Maintenance, May 2024 (#2099)

Various adjustments to MSAL-only and MSAL/Broker Tests. Some tests were
removed to be ran manually as part of release, some tests were adjusted,
and some test files were removed corresponding to tests that have been
migrated to integration testing. Changes in common were taken in to fix
some broker automation.

Common:
AzureAD/microsoft-authentication-library-common-for-android#2406

Author: fadidurah

common

@@ -52,7 +52,6 @@
 @SupportedBrokers(brokers = BrokerHost.class)
 @RetryOnFailure(retryCount = 2)
 @LocalBrokerHostDebugUiTest
-@Ignore("Seeing an error related to encryption at the 'getAccounts()' steps")
 public class TestCase1561136 extends AbstractMsalBrokerTest {
 
     @Test

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/brokerapi/TestCase1561136.java

@@ -124,6 +124,9 @@ public void test_833514() throws MsalException, InterruptedException, LabApiExce
                         .sessionExpected(false)
                         .build();
 
+        // Give the sample a bit of time to replicate being in shared device mode
+        Thread.sleep(TimeUnit.SECONDS.toMillis(5));
+
         // sign in into Azure Sample App
         azureSampleApp.signInWithSingleAccountFragment(username2, password2, getBrowser(), false, microsoftStsPromptHandlerParameters);
 

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/flw/TestCase833514.java

@@ -55,6 +55,7 @@
 import com.microsoft.identity.labapi.utilities.exception.LabApiException;
 
 import org.junit.Assert;
+import org.junit.Ignore;
 import org.junit.Test;
 
 import java.util.Arrays;
@@ -64,6 +65,7 @@
 // https://identitydivision.visualstudio.com/DevEx/_workitems/edit/833515
 @SupportedBrokers(brokers = {BrokerMicrosoftAuthenticator.class, BrokerHost.class})
 @RetryOnFailure(retryCount = 2)
+@Ignore("This one is proving very inconsistent due to Edge Ui, should be ran manually")
 public class TestCase833515 extends AbstractMsalBrokerTest {
 
     @Test

msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/flw/TestCase833515.java

@@ -45,10 +45,10 @@ import java.util.*
 @SupportedBrokers(brokers = [BrokerHost::class])
 @LocalBrokerHostDebugUiTest
 @RetryOnFailure
-class TestCase2637829 : AbstractMsaBrokerTest() {
+class TestCase2637829And2637846 : AbstractMsaBrokerTest() {
     @Test
     @Throws(Throwable::class)
-    fun test_2637829() {
+    fun test_2637829_2637846() {
         val username = mLabAccount.username
         val password = mLabAccount.password
         val msalSdk = MsalSdk()

…p/testpass/broker/msa/TestCase2637829.kt …/broker/msa/TestCase2637829And2637846.ktmsalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/msa/TestCase2637829.kt renamed to msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/msa/TestCase2637829And2637846.kt msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/msa/TestCase2637829.kt renamed to msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/msa/TestCase2637829And2637846.kt

@@ -38,7 +38,7 @@
 import org.junit.Test;
 
 // Nested app auth with US Gov accunt
-// https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2702948
+// https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2703171
 @LocalBrokerHostDebugUiTest
 @SupportedBrokers(brokers = {BrokerHost.class})
 public class TestCase2703171 extends AbstractMsalBrokerTest {