We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 330c435 commit 41e5b4cCopy full SHA for 41e5b4c
1 file changed
tests/Microsoft.Identity.Test.Unit/CoreTests/HttpTests/HttpClientFactoryTests.cs
@@ -93,7 +93,8 @@ public void TestGetHttpClient_DoesNotLeakHttpClients()
93
94
// Assert - CreateHttpClient should be called exactly once.
95
// Before the fix, GetOrAdd(key, CreateHttpClient()) eagerly evaluates
96
- // CreateHttpClient() on every call, leaking HttpClientHandler sockets.
+ // CreateHttpClient() on every call, causing unnecessary throwaway
97
+ // HttpClient/HttpClientHandler allocations.
98
Assert.AreEqual(1, created,
99
$"CreateHttpClient was called {created} times for 3 lookups. " +
100
"Use GetOrAdd(key, factory_delegate) to avoid creating throwaway HttpClient instances.");
0 commit comments