fix: make System.ValueTuple conditional on net462 only (#5894) (#5906)

* fix: make System.ValueTuple conditional on net462 only (#5894)

System.ValueTuple was an unconditional PackageReference, causing it to
appear in the NuGet dependency group for all TFMs including net472.
On .NET Framework 4.7+ ValueTuple is in-box, so the NuGet package
generates harmful binding redirects in Web.Config that cause runtime
failures.

Changes:
- Microsoft.Identity.Client.csproj: restrict direct ValueTuple ref to
  net462 (the only TFM that needs it) and suppress the transitive dep
  from System.Formats.Asn1 on net472 via PrivateAssets/ExcludeAssets.
- Remove unnecessary ValueTuple refs from Microsoft.Identity.Lab.Api
  and Microsoft.Identity.Test.Common (both netstandard2.0-only).

Fixes #5894

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update Microsoft.Identity.Client.csproj

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: gladjohn

src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj

@@ -154,12 +154,22 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.IdentityModel.Abstractions" />
+  </ItemGroup>
+
+  <!-- System.ValueTuple is in-box starting with .NET Framework 4.7; only net462 needs the package. -->
+  <ItemGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetDesktop462)'">
     <PackageReference Include="System.ValueTuple" />
   </ItemGroup>
 
+  <!-- Suppress transitive System.ValueTuple from System.Formats.Asn1 on net472+, where it is in-box
+       and the NuGet package causes harmful binding redirects (see #5894). -->
+  <ItemGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetDesktop472)'">
+    <PackageReference Include="System.ValueTuple" PrivateAssets="All" ExcludeAssets="All" />
+  </ItemGroup>
+
   <ItemGroup Label="For public api analyzer support">
     <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" />
     <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Unshipped.txt" />
   </ItemGroup>
 
-</Project>
+</Project>

src/client/Microsoft.Identity.Lab.Api/Microsoft.Identity.Lab.Api.csproj

@@ -37,7 +37,6 @@
     <PackageReference Include="System.Threading.Tasks" />
     <PackageReference Include="System.Threading.Tasks.Parallel" />
     <PackageReference Include="System.Threading.Thread" />
-    <PackageReference Include="System.ValueTuple" />
   </ItemGroup>
 
   <ItemGroup>

tests/Microsoft.Identity.Test.Common/Microsoft.Identity.Test.Common.csproj

@@ -20,7 +20,6 @@
     <PackageReference Include="System.Threading.Tasks" />
     <PackageReference Include="System.Threading.Tasks.Parallel" />
     <PackageReference Include="System.Threading.Thread" />
-    <PackageReference Include="System.ValueTuple" />
   </ItemGroup>
 
   <ItemGroup>