-
Notifications
You must be signed in to change notification settings - Fork 403
Added support for WithArributeTokens #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
dd32f62
added initial changes for withattributetoken
4gust 59667b7
added the api in the public api list
4gust f3967d7
Update src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenOnB…
4gust bb0dd14
Apply suggestions from code review
4gust 0ed4e23
reduce code duplication, added null safty
4gust 4d646fc
merged with the copilot changes
4gust a563597
Merge branch 'main' into 4gust/with-attr-token
4gust 169fead
applied copilot suggessions
4gust 4373f36
Merge branch '4gust/with-attr-token' of https://github.com/AzureAD/mi…
4gust 14ae88c
updated the api unshipped doc
4gust faf858c
moved acquire token to base class
4gust 63fdf9f
resolving comments
4gust 2ebec4f
Update AbstractConfidentialClientAcquireTokenParameterBuilderExtensio…
4gust 3078d92
Restrict WithAttributeTokens to confidential client builders only
Copilot aa5c089
Merge branch 'main' into 4gust/with-attr-token
4gust 0bbdda7
updated tests and comments on the code.
4gust df20f25
Merge branch '4gust/with-attr-token' of https://github.com/AzureAD/mi…
4gust 07af457
resolved comments
4gust 1602c6a
updated the withExtraParameter function
4gust 65e6b91
updated the older function for the WithExtraBodyParameters
4gust 513d50d
sorted the token order to maintain the same cache key hit. added tests
4gust 2265042
removed logging check
4gust 9aa3237
resolved comments
4gust 42c89b3
added unit test for cache hit
4gust 6ffc068
Update WithAttributeTokensTests.cs
4gust 8aa44f7
Merge branch 'main' into 4gust/with-attr-token
4gust 9e3c714
Add OBO cache isolation recommendation to WithAttributeTokens XML docs
Copilot c37263f
Merge branch 'main' into 4gust/with-attr-token
4gust File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithAttributeTokens<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.IEnumerable<string> attributeTokens) -> T | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithExtraBodyParameters<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.Dictionary<string, System.Func<System.Threading.CancellationToken, System.Threading.Tasks.Task<string>>> extraBodyParams) -> T | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void | ||
| const Microsoft.Identity.Client.MsalError.InvalidCredentialMaterial = "invalid_credential_material" -> string | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.get -> bool | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.init -> void | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void |
6 changes: 4 additions & 2 deletions
6
src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithAttributeTokens<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.IEnumerable<string> attributeTokens) -> T | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithExtraBodyParameters<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.Dictionary<string, System.Func<System.Threading.CancellationToken, System.Threading.Tasks.Task<string>>> extraBodyParams) -> T | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void | ||
| const Microsoft.Identity.Client.MsalError.InvalidCredentialMaterial = "invalid_credential_material" -> string | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.get -> bool | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.init -> void | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void |
6 changes: 4 additions & 2 deletions
6
src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithAttributeTokens<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.IEnumerable<string> attributeTokens) -> T | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithExtraBodyParameters<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.Dictionary<string, System.Func<System.Threading.CancellationToken, System.Threading.Tasks.Task<string>>> extraBodyParams) -> T | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void | ||
| const Microsoft.Identity.Client.MsalError.InvalidCredentialMaterial = "invalid_credential_material" -> string | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.get -> bool | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.init -> void | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void |
6 changes: 4 additions & 2 deletions
6
src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithAttributeTokens<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.IEnumerable<string> attributeTokens) -> T | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithExtraBodyParameters<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.Dictionary<string, System.Func<System.Threading.CancellationToken, System.Threading.Tasks.Task<string>>> extraBodyParams) -> T | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void | ||
| const Microsoft.Identity.Client.MsalError.InvalidCredentialMaterial = "invalid_credential_material" -> string | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.get -> bool | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.init -> void | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void |
6 changes: 4 additions & 2 deletions
6
src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithAttributeTokens<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.IEnumerable<string> attributeTokens) -> T | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithExtraBodyParameters<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.Dictionary<string, System.Func<System.Threading.CancellationToken, System.Threading.Tasks.Task<string>>> extraBodyParams) -> T | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void | ||
| const Microsoft.Identity.Client.MsalError.InvalidCredentialMaterial = "invalid_credential_material" -> string | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.get -> bool | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.init -> void | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void |
6 changes: 4 additions & 2 deletions
6
src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithAttributeTokens<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.IEnumerable<string> attributeTokens) -> T | ||
| static Microsoft.Identity.Client.Extensibility.AbstractConfidentialClientAcquireTokenParameterBuilderExtension.WithExtraBodyParameters<T>(this Microsoft.Identity.Client.AbstractConfidentialClientAcquireTokenParameterBuilder<T> builder, System.Collections.Generic.Dictionary<string, System.Func<System.Threading.CancellationToken, System.Threading.Tasks.Task<string>>> extraBodyParams) -> T | ||
|
4gust marked this conversation as resolved.
|
||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void | ||
| const Microsoft.Identity.Client.MsalError.InvalidCredentialMaterial = "invalid_credential_material" -> string | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.get -> bool | ||
| Microsoft.Identity.Client.AppConfig.CertificateOptions.SendCertificateOverMtls.init -> void | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.get -> System.Guid | ||
| Microsoft.Identity.Client.AssertionRequestOptions.CorrelationId.set -> void | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.