Add 63 unit tests for parsing/logic edge cases in IdToken, WsTrust, AuthorizationResult, ThrottlingCache, Base64Url by gladjohn · Pull Request #5907 · AzureAD/microsoft-authentication-library-for-dotnet

gladjohn · 2026-04-03T20:18:13Z

Summary

Adds 63 unit tests across 5 test files targeting real parsing and logic edge cases in Microsoft.Identity.Client. Each test validates specific behavioral contracts that would catch actual regressions.

Also marks ConcurrentHashSet<T> (copied from i3arnon/ConcurrentHashSet) as [ExcludeFromCodeCoverage] since it's external code that shouldn't affect MSAL coverage metrics.

Test Files

File	Tests	Target	Key Scenarios
`WsTrustResponseExtendedTests`	13	`WsTrustResponse`	SOAP fault parsing, missing body/fault fallback, WsTrust13 vs 2005, SAML1 preference, skipped responses
`AuthorizationResultExtendedTests`	18	`AuthorizationResult`	Null/empty URI, error subcodes, `msauth://` scheme, `FromPostData`, `FromStatus` factory
`IdTokenExtendedTests`	11	`IdToken`	Null/empty/malformed JWT, claim mapping, `GetUniqueId` fallback (oid→sub), missing issuer, `ClaimsPrincipal`
`Base64UrlHelpersExtendedTests`	13	`Base64UrlHelpers`	Null handling, URL-safe char validation, padding variants, invalid input, padded base64 decoding
`ThrottlingCacheExtendedTests`	8	`ThrottlingCache`	Clear/IsEmpty, newer entry replacement, older-doesn't-replace-newer, cleanup of expired entries

Production Code Change

ConcurrentHashSet.cs: Added [ExcludeFromCodeCoverage] attribute (class is copied from external OSS repo)

Validation

✅ Build: 0 errors, 0 warnings
✅ Tests: All 63 new tests pass on both net48 and net8.0

Copilot

Pull request overview

Adds a new set of unit tests to increase coverage for key MSAL.NET utility and parsing components in Microsoft.Identity.Client, without changing production code.

Changes:

Added extended unit tests for AuthorizationResult, IdToken, WsTrustResponse, ThrottlingCache, TokenCacheNotificationArgs, TraceTelemetryConfig, Base64UrlHelpers, and ConcurrentHashSet<T>.
Expanded edge-case coverage (null/empty inputs, parsing fallbacks, constructor overloads, cache cleanup/expiry behavior, and concurrency basics).
Introduced new test files across WebUI, Core, Util, Throttling, Cache, and Telemetry test areas.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/Microsoft.Identity.Test.Unit/WebUITests/AuthorizationResultExtendedTests.cs	Adds coverage for `AuthorizationResult` creation from URI/post body/status paths.
tests/Microsoft.Identity.Test.Unit/UtilTests/ConcurrentHashSetTests.cs	Adds functional and basic concurrency tests for `ConcurrentHashSet<T>`.
tests/Microsoft.Identity.Test.Unit/UtilTests/Base64UrlHelpersExtendedTests.cs	Adds coverage for Base64Url encode/decode edge cases and round trips.
tests/Microsoft.Identity.Test.Unit/Throttling/ThrottlingCacheExtendedTests.cs	Adds coverage for `ThrottlingCache` clear/empty/update/cleanup behavior.
tests/Microsoft.Identity.Test.Unit/TelemetryTests/TraceTelemetryConfigTests.cs	Adds coverage for default `TraceTelemetryConfig` values (obsolete API).
tests/Microsoft.Identity.Test.Unit/CoreTests/WsTrustTests/WsTrustResponseExtendedTests.cs	Adds coverage for SOAP fault parsing and WsTrust response parsing behavior.
tests/Microsoft.Identity.Test.Unit/CoreTests/IdTokenExtendedTests.cs	Adds coverage for `IdToken.Parse` error paths and claim mapping/fallbacks.
tests/Microsoft.Identity.Test.Unit/CacheTests/TokenCacheNotificationArgsExtendedTests.cs	Adds coverage for `TokenCacheNotificationArgs` constructor overloads and defaults.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

bgavrilMS

I don't think this is a good idea. It artificially increases code coverage, but do you know they capture the correct behavior?

gladjohn · 2026-04-26T13:38:35Z

I don't think this is a good idea. It artificially increases code coverage, but do you know they capture the correct behavior?

Fair point. Dropped ~55 tests that artificially inflated coverage (ConcurrentHashSet, TokenCacheNotificationArgs constructors, TraceTelemetryConfig constants, redundant Base64Url round-trips). The remaining ~63 tests all validate real parsing/logic: JWT claim mapping and fallback, SOAP fault parsing, authorization URI handling, and throttling cache semantics. Also added [ExcludeFromCodeCoverage] to ConcurrentHashSet since it's copied from i3arnon/ConcurrentHashSet.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Coverage improvements for Microsoft.Identity.Client: - Line coverage: 82.58% -> 84.20% (+1.62%, +387 lines) - Branch coverage: 72.91% -> 75.09% (+2.18%, +128 branches) New test files: - ConcurrentHashSetTests: comprehensive tests for thread-safe collection - Base64UrlHelpersExtendedTests: edge cases for encoding/decoding - IdTokenExtendedTests: null/empty/malformed JWT, claim mapping - WsTrustResponseExtendedTests: SOAP fault parsing, SAML selection - AuthorizationResultExtendedTests: URI/PostData parsing edge cases - ThrottlingCacheExtendedTests: cleanup, clear, miss paths - TokenCacheNotificationArgsExtendedTests: constructor overloads - TraceTelemetryConfigTests: basic config properties Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Fix Assert.DoesNotContain parameter order in Base64UrlHelpersExtendedTests - Replace Thread.Sleep with deterministic ThrottlingCacheEntry 3-arg ctor - Fix AddAndCleanup_SameKey_KeepsOlderIfNewer to actually test the scenario - Use cleanup interval of 0ms instead of Thread.Sleep for cleanup test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ption assertion - Merge Parse_SingleSegment_ThrowsMsalClientException and Parse_SingleSegment_HasCorrectErrorCode into a single test that verifies both the exception type and error code via Assert.Throws - Replace weak Parse_InvalidBase64Payload_Throws (caught both MsalClientException and FormatException) with Parse_InvalidBase64Payload_ThrowsFormatException that asserts the specific exception type Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Drop ~55 tests that artificially inflate coverage without validating behavior: - Remove ConcurrentHashSetTests.cs (tests for copied OSS class) - Remove TokenCacheNotificationArgsExtendedTests.cs (constructor/property tests) - Remove TraceTelemetryConfigTests.cs (constants on obsolete class) - Remove 9 redundant Base64Url round-trip tests Fix remaining ~63 tests that verify real parsing/logic: - ThrottlingCache: use negative cleanup interval for deterministic test - Base64Url: remove unnecessary IEnumerable cast in Assert.HasCount - Base64Url: test actual padded base64 input instead of re-encoding Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Class is copied from i3arnon/ConcurrentHashSet and should not contribute to MSAL coverage metrics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

gladjohn requested a review from a team as a code owner April 3, 2026 20:18

Copilot AI review requested due to automatic review settings April 3, 2026 20:18

Copilot started reviewing on behalf of gladjohn April 3, 2026 20:19 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

Robbie-Microsoft reviewed Apr 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 22, 2026 12:48

Copilot started reviewing on behalf of gladjohn April 22, 2026 12:49 View session

gladjohn requested a review from Robbie-Microsoft April 22, 2026 12:53

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/Throttling/ThrottlingCacheExtendedTests.cs

Comment thread tests/Microsoft.Identity.Test.Unit/UtilTests/Base64UrlHelpersExtendedTests.cs Outdated

Robbie-Microsoft reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/Throttling/ThrottlingCacheExtendedTests.cs Outdated

Robbie-Microsoft reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/UtilTests/Base64UrlHelpersExtendedTests.cs Outdated

bgavrilMS requested changes Apr 22, 2026

View reviewed changes

bgavrilMS reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/UtilTests/Base64UrlHelpersExtendedTests.cs

bgavrilMS reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/UtilTests/ConcurrentHashSetTests.cs Outdated

bgavrilMS reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/CoreTests/IdTokenExtendedTests.cs

bgavrilMS reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/CacheTests/TokenCacheNotificationArgsExtendedTests.cs Outdated

Copilot AI review requested due to automatic review settings April 26, 2026 13:34

Copilot started reviewing on behalf of gladjohn April 26, 2026 13:34 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

gladjohn changed the title ~~Adds 119 unit tests to improve code coverage (+1.62% line, +2.18% branch)~~ Add 63 unit tests for parsing/logic edge cases in IdToken, WsTrust, AuthorizationResult, ThrottlingCache, Base64Url Apr 28, 2026

bgavrilMS approved these changes Apr 28, 2026

View reviewed changes

gladjohn and others added 6 commits April 28, 2026 21:58

Exclude ConcurrentHashSet from code coverage

4480bdb

Class is copied from i3arnon/ConcurrentHashSet and should not contribute to MSAL coverage metrics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove unused using directives flagged by Copilot reviewer

fbca87b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 28, 2026 20:58

bgavrilMS force-pushed the gladjohn/code_coverage branch from 4312219 to fbca87b Compare April 28, 2026 20:58

Copilot started reviewing on behalf of bgavrilMS April 28, 2026 20:59 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Merge branch 'main' into gladjohn/code_coverage

6918e5f

Conversation

gladjohn commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Files

Production Code Change

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bgavrilMS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gladjohn commented Apr 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gladjohn commented Apr 3, 2026 •

edited

Loading