Add GovFr, GovDe, GovSg to AzureCloudInstance enum#6023
Merged
Conversation
Add sovereign cloud values to AzureCloudInstance for Bleu (France), Delos (Germany), and GovSG (Singapore). Update AuthorityInfo.GetCloudUrl() to map the new values to their login endpoints and update all PublicAPI.Unshipped.txt files. Fixes #5706 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds three new sovereign cloud options to Microsoft.Identity.Client.AzureCloudInstance so callers can use WithAuthority(AzureCloudInstance.<cloud>, tenantId) instead of manually composing authority URIs.
Changes:
- Extended
AzureCloudInstancewithGovFr,GovDe, andGovSgenum values (with XML docs). - Updated
AuthorityInfo.GetCloudUrl()to map the new enum values to their sovereign login endpoints. - Registered the new public API surface in all target framework
PublicAPI.Unshipped.txtfiles.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/client/Microsoft.Identity.Client/AppConfig/AzureCloud.cs | Adds new AzureCloudInstance enum values for GovFr/GovDe/GovSg. |
| src/client/Microsoft.Identity.Client/AppConfig/AuthorityInfo.cs | Maps the new enum values to login.sovcloud-identity.{fr,de,sg} in GetCloudUrl(). |
| src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt | Registers new enum members in public API surface (netstandard2.0). |
| src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt | Registers new enum members in public API surface (net8.0). |
| src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt | Registers new enum members in public API surface (net8.0-ios). |
| src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt | Registers new enum members in public API surface (net8.0-android). |
| src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt | Registers new enum members in public API surface (net472). |
| src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt | Registers new enum members in public API surface (net462). |
…ings Extend TestAuthorityPermutations with DataRow entries for the three new AzureCloudInstance values to verify GetCloudUrl returns the correct login.sovcloud-identity.* endpoints. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…ublicAPI.Unshipped.txt conflicts
Contributor
Merge conflicts resolved in commit |
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…oud-enum-5706 # Conflicts: # src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt
Contributor
Merge conflicts resolved in commit |
gladjohn
approved these changes
Jun 10, 2026
Avery-Dunn
approved these changes
Jun 10, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
gladjohn
approved these changes
Jun 10, 2026
This was referenced Jun 20, 2026
Open
fix: Bump Microsoft.Identity.Client from 4.84.2 to 4.85.0
Halceyon/open-telemetry-trace-listener#199
Closed
Closed
Closed
Open
Merged
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three new sovereign cloud values to the
AzureCloudInstanceenum, enabling developers to use the familiarWithAuthority(AzureCloudInstance.GovFr, tenantId)pattern instead of manually specifying authority URIs.GovFrhttps://login.sovcloud-identity.frGovDehttps://login.sovcloud-identity.deGovSghttps://login.sovcloud-identity.sgChanges proposed in this request
AzureCloud.cs— AddedGovFr(5),GovDe(6),GovSg(7) enum values with XML doc commentsAuthorityInfo.cs— UpdatedGetCloudUrl()switch to map new values to their login endpointsPublicAPI.Unshipped.txt— Registered the new public API surface; contains only the newGovFr/GovDe/GovSgenum entries (all prior entries were moved toPublicAPI.Shipped.txtin the 4.84.2 release onmain)Testing
Unit tests added in
PublicClientApplicationBuilderTests.csvalidating that the expected authority URL is produced for each new enum value (GovFr,GovDe,GovSg), coveringcommonandorganizationsaudiences consistent with existing cloud tests.Performance impact
No performance impact.
Documentation