Skip to content

Commit 7751075

Browse files
committed
Fix for review comments
1 parent 34a34ee commit 7751075

2 files changed

Lines changed: 21 additions & 19 deletions

File tree

msal4j-persistence-extension/target/test-classes/log4j.properties

Lines changed: 0 additions & 10 deletions
This file was deleted.

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParametersTest.java

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,25 +98,35 @@ void testBuilder_conflictingParameters() {
9898
}
9999

100100
@Test
101-
void testBuilder_queryResponseModeIsOverriddenToFormPost() throws UnsupportedEncodingException {
101+
void testBuilder_responseMode() throws UnsupportedEncodingException {
102102
PublicClientApplication app = PublicClientApplication.builder("client_id").build();
103103

104104
String redirectUri = "http://localhost:8080";
105105
Set<String> scope = Collections.singleton("scope");
106106

107-
// Test that when QUERY is passed (deprecated), it's overridden to FORM_POST
108107
AuthorizationRequestUrlParameters parameters =
109108
AuthorizationRequestUrlParameters
110109
.builder(redirectUri, scope)
111-
.responseMode(ResponseMode.QUERY) // Deprecated - should be overridden
110+
.responseMode(ResponseMode.QUERY) // This should be overridden to FORM_POST
112111
.build();
113112

114-
// Verify that the responseMode is overridden to FORM_POST
115-
assertEquals(ResponseMode.FORM_POST, parameters.responseMode(),
116-
"ResponseMode.QUERY should be overridden to ResponseMode.FORM_POST");
113+
assertEquals(parameters.responseMode(), ResponseMode.FORM_POST);
114+
assertEquals(parameters.redirectUri(), redirectUri);
115+
assertEquals(parameters.scopes().size(), 4);
116+
117+
assertNull(parameters.loginHint());
118+
assertNull(parameters.codeChallenge());
119+
assertNull(parameters.codeChallengeMethod());
120+
assertNull(parameters.correlationId());
121+
assertNull(parameters.nonce());
122+
assertNull(parameters.prompt());
123+
assertNull(parameters.state());
117124

118125
URL authorizationUrl = app.getAuthorizationRequestUrl(parameters);
119126

127+
assertEquals(authorizationUrl.getHost(), "login.microsoftonline.com");
128+
assertEquals(authorizationUrl.getPath(), "/common/oauth2/v2.0/authorize");
129+
120130
Map<String, String> queryParameters = new HashMap<>();
121131
String query = authorizationUrl.getQuery();
122132

@@ -128,8 +138,10 @@ void testBuilder_queryResponseModeIsOverriddenToFormPost() throws UnsupportedEnc
128138
URLDecoder.decode(pair.substring(idx + 1), "UTF-8"));
129139
}
130140

131-
// Verify that the actual response_mode parameter is "form_post", not "query"
132-
assertEquals("form_post", queryParameters.get("response_mode"),
133-
"response_mode query parameter should be 'form_post' even when QUERY was specified");
141+
assertEquals(queryParameters.get("scope"), "openid profile offline_access scope");
142+
assertEquals(queryParameters.get("response_type"), "code");
143+
assertEquals(queryParameters.get("redirect_uri"), "http://localhost:8080");
144+
assertEquals(queryParameters.get("client_id"), "client_id");
145+
assertEquals(queryParameters.get("response_mode"), "form_post");
134146
}
135147
}

0 commit comments

Comments
 (0)