Address PR review feedback: fix remaining reversed assertEquals args, use StandardCharsets.UTF_8

- Fix reversed assertEquals in WSTrustRequestTest (StringEscapeUtils as expected)
- Fix reversed assertEquals in HelperAndUtilityTest (convertedInternalMap.size as expected)
- Use StandardCharsets.UTF_8 instead of string literal in SeleniumDiagnostics

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Avery-Dunn

msal4j-sdk/src/integrationtest/java/infrastructure/SeleniumDiagnostics.java

@@ -13,6 +13,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -108,7 +109,7 @@ static void capturePageSource(WebDriver driver, String filePrefix) {
             content.append(pageSource);
 
             Path destination = getOutputPath(filePrefix + ".html");
-            Files.write(destination, content.toString().getBytes("UTF-8"));
+            Files.write(destination, content.toString().getBytes(StandardCharsets.UTF_8));
             LOG.info("Page source saved: {}", destination);
         } catch (Exception e) {
             LOG.warn("Failed to capture page source: {}", e.getMessage());
@@ -142,7 +143,7 @@ static void captureBrowserLogs(WebDriver driver, String filePrefix) {
             }
 
             Path destination = getOutputPath(filePrefix + "-console.log");
-            Files.write(destination, content.toString().getBytes("UTF-8"));
+            Files.write(destination, content.toString().getBytes(StandardCharsets.UTF_8));
             LOG.info("Browser logs saved: {}", destination);
         } catch (Exception e) {
             LOG.warn("Failed to capture browser logs: {} (this may be expected if logging prefs are not supported)", e.getMessage());

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/HelperAndUtilityTest.java

@@ -78,7 +78,7 @@ void StringHelper_convertToMultiValueMap() {
         assertNotNull(convertedInternalMap, "Converted map should not be null");
         assertNotNull(methodReturnedMap, "Method returned map should not be null");
 
-        assertEquals(methodReturnedMap.size(), convertedInternalMap.size(), "Maps should have the same size");
+        assertEquals(convertedInternalMap.size(), methodReturnedMap.size(), "Maps should have the same size");
 
         for (String key : convertedInternalMap.keySet()) {
             assertTrue(methodReturnedMap.containsKey(key), "Method returned map should contain key: " + key);

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/WSTrustRequestTest.java

@@ -51,7 +51,7 @@ void escapeXMLElementDataTest() {
         String XML_ESCAPED_DATA = "o_!as & a34~'fe<> " a1";
 
         assertEquals(XML_ESCAPED_DATA, WSTrustRequest.escapeXMLElementData(DATA_TO_ESCAPE));
-        assertEquals(WSTrustRequest.escapeXMLElementData(DATA_TO_ESCAPE),
-                StringEscapeUtils.escapeXml10(DATA_TO_ESCAPE));
+        assertEquals(StringEscapeUtils.escapeXml10(DATA_TO_ESCAPE),
+                WSTrustRequest.escapeXMLElementData(DATA_TO_ESCAPE));
     }
 }