Skip to content

Commit c318d3b

Browse files
committed
Update AuthorizationRequestUrlParameters.java
1 parent 7751075 commit c318d3b

1 file changed

Lines changed: 11 additions & 13 deletions

File tree

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -113,18 +113,9 @@ private AuthorizationRequestUrlParameters(Builder builder) {
113113
}
114114

115115
if (builder.responseMode != null) {
116-
// Override QUERY with FORM_POST as QUERY is deprecated
117-
if (builder.responseMode == ResponseMode.QUERY) {
118-
LOG.warn("ResponseMode.QUERY is deprecated and will be removed in a future release. " +
119-
"Automatically overriding to ResponseMode.FORM_POST.");
120-
this.responseMode = ResponseMode.FORM_POST;
121-
requestParameters.put("response_mode",
122-
ResponseMode.FORM_POST.toString());
123-
} else {
124-
this.responseMode = builder.responseMode;
125-
requestParameters.put("response_mode",
126-
builder.responseMode.toString());
127-
}
116+
this.responseMode = builder.responseMode;
117+
requestParameters.put("response_mode",
118+
builder.responseMode.toString());
128119
} else {
129120
this.responseMode = ResponseMode.FORM_POST;
130121
requestParameters.put("response_mode",
@@ -380,7 +371,14 @@ public Builder nonce(String val) {
380371
* @deprecated ResponseMode.QUERY is deprecated. If you pass ResponseMode.QUERY, it will be automatically overridden to ResponseMode.FORM_POST.
381372
*/
382373
public Builder responseMode(ResponseMode val) {
383-
this.responseMode = val;
374+
// Override QUERY with FORM_POST as QUERY is deprecated
375+
if (val == ResponseMode.QUERY) {
376+
LOG.warn("ResponseMode.QUERY is deprecated and will be removed in a future release. " +
377+
"Automatically overriding to ResponseMode.FORM_POST.");
378+
this.responseMode = ResponseMode.FORM_POST;
379+
} else {
380+
this.responseMode = val;
381+
}
384382
return self();
385383
}
386384

0 commit comments

Comments
 (0)